From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376D9C4332F for ; Tue, 22 Nov 2022 15:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80AF96B0075; Tue, 22 Nov 2022 10:06:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BAC28E0001; Tue, 22 Nov 2022 10:06:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683436B007B; Tue, 22 Nov 2022 10:06:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 59D9C6B0075 for ; Tue, 22 Nov 2022 10:06:30 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 33E62120FCC for ; Tue, 22 Nov 2022 15:06:30 +0000 (UTC) X-FDA: 80161404540.30.C6DB300 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf24.hostedemail.com (Postfix) with ESMTP id F33FC18001E for ; Tue, 22 Nov 2022 15:06:27 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669129585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jgAMdI+izwDeEvpgX4m0VI03W8NKclkKP90RLZ9WIgA=; b=1+tAieLZ/HZeaJFKtaHw4vi1gZimlzue2u9cqJzeYDjmsND6FbuFRnsrDHMvqStd36WDQ5 zdowaOcylQk455fJ8gN2mYKy7pFOIAxFF95RqMT8yTAwNFC6fSK4IwhbQZveqN6smCI1AF hErxnuE2xff4VQHXbS3FOhYgbu4ynarw8Tk5xxHgMQ7x/+i8dFEGuASdL5vwujgHwe+ifr lt6gA1frFaTT7rmGpRAq/CRtNld78MLdVjyWihZJYmfuwkF04TMWB4QcgpzaOA9WO0v1++ hNeq4/cElSkc6ZLN2S2IHkEcXyLaoba4w/8ynTHUHZWq10sDQ2f0zv+e0ytxLA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669129585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jgAMdI+izwDeEvpgX4m0VI03W8NKclkKP90RLZ9WIgA=; b=BOGG+iOwzQCE8G/W4MRT93mk1FQyIcC0bvXLAIXGPpJZzsusE/JeB0Bpc5TtS53cfoLwQZ 66AGLC1EvkM65rAw== To: Peter Zijlstra , Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dave.hansen@intel.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v7 06/20] x86/virt/tdx: Shut down TDX module in case of error In-Reply-To: References: <48505089b645019a734d85c2c29f3c8ae2dbd6bd.1668988357.git.kai.huang@intel.com> Date: Tue, 22 Nov 2022 16:06:25 +0100 Message-ID: <87bkozgham.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669129588; a=rsa-sha256; cv=none; b=h1vw2chqHv7UhRvAcTomoUaCgi+7OMq83ohXBHRnfjpVXSMzkdJk0h5p+7rHr6cRR0zQ0b 27908PJmSdjAmulBjTJbW6nap2sNHXGIwyhUKRcYLR1clQSPwcLGjpeOTtX06e5vo72i9E WdXTbiDIrL5T7QF8SaruSqPRT5H76OQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=1+tAieLZ; dkim=pass header.d=linutronix.de header.s=2020e header.b=BOGG+iOw; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669129588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jgAMdI+izwDeEvpgX4m0VI03W8NKclkKP90RLZ9WIgA=; b=lmgxfUfCWXyI7g4vEP9QzP9n8tOsOmfTfltMR671CcLs/XlFZckDVUAXexj0Uvg9TLc16N Qi3adgDdoTfQINIrdt7gDxqjQQB8LbPh76lZVZh4JwvllrrVMokbi690a89adeTB9tsWaV ++QbSYn2od4NYXrsiQSfuAGwxN0c0xU= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F33FC18001E Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=1+tAieLZ; dkim=pass header.d=linutronix.de header.s=2020e header.b=BOGG+iOw; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspam-User: X-Stat-Signature: saxbqo9iae79nwej8nsoxymohb6g975y X-HE-Tag: 1669129587-881208 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000153, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22 2022 at 10:20, Peter Zijlstra wrote: > On Mon, Nov 21, 2022 at 01:26:28PM +1300, Kai Huang wrote: > >> Shutting down the TDX module requires calling TDH.SYS.LP.SHUTDOWN on all >> BIOS-enabled CPUs, and the SEMACALL can run concurrently on different >> CPUs. Implement a mechanism to run SEAMCALL concurrently on all online >> CPUs and use it to shut down the module. Later logical-cpu scope module >> initialization will use it too. > > Uhh, those requirements ^ are not met by this: Can run concurrently != Must run concurrently The documentation clearly says "can run concurrently" as quoted above. Thanks, tglx