From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04294C433DB for ; Sun, 28 Mar 2021 14:42:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 692026196E for ; Sun, 28 Mar 2021 14:42:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 692026196E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C2E9A6B0070; Sun, 28 Mar 2021 10:42:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDECF6B0071; Sun, 28 Mar 2021 10:42:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8ABA6B0072; Sun, 28 Mar 2021 10:42:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 8FFAE6B0070 for ; Sun, 28 Mar 2021 10:42:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3A887180ACC54 for ; Sun, 28 Mar 2021 14:42:05 +0000 (UTC) X-FDA: 77969547810.16.86215F0 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 3ACCBA0000FC for ; Sun, 28 Mar 2021 14:42:03 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1616942523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D54Z2PmLCo200yXOSvaj2hVPC2HaVunYq4YcYHV7CLI=; b=nOSANqfo4EtIMAP5mGifyuzW2Af52m5HsKAtyMqUUKMzc0XR6FoAXid/2jQwT1JZL0bk7z XPx6W8UmnTT3Jx8MOw6POYFwlaSRgC40XHyAM5M5FsbPbyOmckgM3CeZ6439glilf+vtSq sV/a3k181wHYDoGE2YkUj9wK8HnMhNzpeJaVEDbXe5/Xjgk8QNWJBHO+6uqjcNoR+FXFCZ yESHY04k4zxypQtFZ8DrCTzA11YAhm/q9JYc/rH+HEA/Aq5HxI9j53+8VORvF9pvloSBK+ YRfZClUyO8fKSqfnrPgq+eK5DxXnt0UkMYLx1a/LsXp/dt707mjcotvIBxFSaA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1616942523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D54Z2PmLCo200yXOSvaj2hVPC2HaVunYq4YcYHV7CLI=; b=2/R47s1sLunWDFbaoDjixBAOVW6iJ5IR9uZH6pLWwX8sxIDwqn63g4zVRcfcZhQBqAGFeV mga+yqnJjOZqMqCQ== To: Kees Cook Cc: Kees Cook , Elena Reshetova , x86@kernel.org, Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , Mark Rutland , Alexander Potapenko , Alexander Popov , Ard Biesheuvel , Jann Horn , Vlastimil Babka , David Hildenbrand , Mike Rapoport , Andrew Morton , Jonathan Corbet , Randy Dunlap , kernel-hardening@lists.openwall.com, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/6] stack: Optionally randomize kernel stack offset each syscall In-Reply-To: <20210319212835.3928492-4-keescook@chromium.org> References: <20210319212835.3928492-1-keescook@chromium.org> <20210319212835.3928492-4-keescook@chromium.org> Date: Sun, 28 Mar 2021 16:42:03 +0200 Message-ID: <87eefzcpc4.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3ACCBA0000FC X-Stat-Signature: zumpwww657gdru1ps369f55ni43f1aeg Received-SPF: none (linutronix.de>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=galois.linutronix.de; client-ip=193.142.43.55 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616942523-926660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kees, On Fri, Mar 19 2021 at 14:28, Kees Cook wrote: > +/* > + * Do not use this anywhere else in the kernel. This is used here because > + * it provides an arch-agnostic way to grow the stack with correct > + * alignment. Also, since this use is being explicitly masked to a max of > + * 10 bits, stack-clash style attacks are unlikely. For more details see > + * "VLAs" in Documentation/process/deprecated.rst VLAs are bad, VLAs to the rescue! :) > + * The asm statement is designed to convince the compiler to keep the > + * allocation around even after "ptr" goes out of scope. > + */ > +void *__builtin_alloca(size_t size); > + > +#define add_random_kstack_offset() do { \ > + if (static_branch_maybe(CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT, \ > + &randomize_kstack_offset)) { \ > + u32 offset = this_cpu_read(kstack_offset); \ Not that it matters on x86, but as this has to be called in the interrupt disabled region of the syscall entry, shouldn't this be a raw_cpu_read(). The asm-generic version has a preempt_disable/enable pair around the raw read for native wordsize reads, otherwise a irqsave/restore pair. __this_cpu_read() is fine as well, but that has an sanity check before the raw read when CONFIG_DEBUG_PREEMPT is on, which is harmless but also pointless in this case. Probably the same for the counterpart this_cpu_write(). Thanks, tglx