From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F243C3F2D1 for ; Fri, 28 Feb 2020 06:48:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3B432469C for ; Fri, 28 Feb 2020 06:48:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3B432469C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 501916B0005; Fri, 28 Feb 2020 01:48:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1466B0006; Fri, 28 Feb 2020 01:48:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C73F6B0007; Fri, 28 Feb 2020 01:48:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 233456B0005 for ; Fri, 28 Feb 2020 01:48:04 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CBA05180AD807 for ; Fri, 28 Feb 2020 06:48:03 +0000 (UTC) X-FDA: 76538606046.24.dogs30_464cd29f4be63 X-HE-Tag: dogs30_464cd29f4be63 X-Filterd-Recvd-Size: 2435 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 06:48:02 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 22:48:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="231018405" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.23]) by fmsmga007.fm.intel.com with ESMTP; 27 Feb 2020 22:47:57 -0800 From: "Huang\, Ying" To: David Hildenbrand Cc: Andrew Morton , , , Dave Hansen , Mel Gorman , "Vlastimil Babka" , Zi Yan , Michal Hocko , Peter Zijlstra , Minchan Kim , Johannes Weiner , Hugh Dickins Subject: Re: [RFC 2/3] mm: Add a new page flag PageLayzyFree() for MADV_FREE References: <20200228033819.3857058-3-ying.huang@intel.com> <0C8CC772-5840-4F0C-9859-C1D7B8BF6025@redhat.com> Date: Fri, 28 Feb 2020 14:47:57 +0800 In-Reply-To: <0C8CC772-5840-4F0C-9859-C1D7B8BF6025@redhat.com> (David Hildenbrand's message of "Fri, 28 Feb 2020 07:13:33 +0100") Message-ID: <87eeuf8axu.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: >> Am 28.02.2020 um 04:38 schrieb Huang, Ying : >>=20 >> =EF=BB=BFFrom: Huang Ying >>=20 >> Now !PageSwapBacked() is used as the flag for the pages freed lazily >> via MADV_FREE. This isn't obvious enough. So Dave suggested to add a >> new page flag for that to improve the code readability. > > This patch subject and description is *really* confusing. You=E2=80=98r= e adding a helper function, not a page flag. It=E2=80=98s a fairly easy r= efactoring. Yes. Thanks for reminding. I will revise this in the next version. Best Regards, Huang, Ying > (Adding new page flags is close to impossible). > > Cheers!