From: Jonathan Corbet <corbet@lwn.net>
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
David Laight <David.Laight@ACULAB.COM>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Akira Yokosawa <akiyks@gmail.com>, Kalle Valo <kvalo@kernel.org>,
"Daniel K ." <daniel@cluded.net>
Subject: Re: [PATCH v2 0/2] coding-style.rst: document BUG() and WARN() rules
Date: Thu, 29 Sep 2022 13:21:43 -0600 [thread overview]
Message-ID: <87k05mgf5k.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220923113426.52871-1-david@redhat.com>
David Hildenbrand <david@redhat.com> writes:
> As it seems to be rather unclear if/when to use BUG(), BUG_ON(),
> VM_BUG_ON(), WARN_ON_ONCE(), ... let's try to document the result of a
> recent discussion.
>
> Details can be found in patch #1.
>
> v1 -> v2:
> * "coding-style.rst: document BUG() and WARN() rules ("do not crash the
> kernel")"
> -> Minor rephrasing / reference fix [John]
> -> Compile fix [Akira]
> * "powerpc/prom_init: drop PROM_BUG()"
> -> Dropped because it will go upstream via a different tree
> * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants"
> -> Rephrase warning message and remove trailing period [John+Joe]
>
> RFC -> v1:
> * "coding-style.rst: document BUG() and WARN() rules ("do not crash the
> kernel")"
> -> Rephrase/extend according to John
> -> Add some details regarding the use of panic()
> * powerpc/prom_init: drop PROM_BUG()
> -> Added
> * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants"
> -> Warn on more variants
It seems we've talked ourselves out on this one, so I've gone ahead and
applied it.
Thanks,
jon
prev parent reply other threads:[~2022-09-29 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 11:34 [PATCH v2 0/2] coding-style.rst: document BUG() and WARN() rules David Hildenbrand
2022-09-23 11:34 ` [PATCH v2 1/2] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel") David Hildenbrand
2022-09-23 11:34 ` [PATCH v2 2/2] checkpatch: warn on usage of VM_BUG_ON() and other BUG variants David Hildenbrand
2022-09-29 19:21 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k05mgf5k.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=David.Laight@ACULAB.COM \
--cc=akiyks@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bhe@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@cluded.net \
--cc=david@redhat.com \
--cc=dwaipayanray1@gmail.com \
--cc=dyoung@redhat.com \
--cc=jani.nikula@linux.intel.com \
--cc=joe@perches.com \
--cc=kvalo@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).