From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F712C4338F for ; Wed, 28 Jul 2021 14:16:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD8F06024A for ; Wed, 28 Jul 2021 14:16:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD8F06024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 57C246B0036; Wed, 28 Jul 2021 10:16:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52BB38D0001; Wed, 28 Jul 2021 10:16:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F3A86B0071; Wed, 28 Jul 2021 10:16:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 21AB66B0036 for ; Wed, 28 Jul 2021 10:16:16 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BAFB11D588 for ; Wed, 28 Jul 2021 14:16:15 +0000 (UTC) X-FDA: 78412196310.18.BB63A4A Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf27.hostedemail.com (Postfix) with ESMTP id 0F1907002742 for ; Wed, 28 Jul 2021 14:16:14 +0000 (UTC) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16SEF1rr146126; Wed, 28 Jul 2021 10:16:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=qoen8XuzfGhS37VebPjiS0Zp8u6zNtChK1bhjXHknu4=; b=agSeZo5Hbp8gTswztQse8qSRn63yOF60BHjl8vOwlkj4mLgJUAr9OmMoHC41AqylOvL5 UIFj7nZurVajAh6emsNgawUrOb0ttxTpo4B3zxhPdm7KBdiqMi8I8cs7Ep7q75Acd9Xk fjyMG23Cggau97jdqVAB1+1wkEG9p068wo21D0Yd994oRR+aJYBQg0mB+GSBSf/JNYki sEC6NN72zb8pxv7lHz5mYTdWv2VZd6yWYHK5Rw9+/R/IZSWCZ0RmCAKVLmNwKjjpvcS+ DHmEFXfJE/A5zGZjnuGEIlkqiP46AgiYRWH9k6nhtRr3gdYC/THKojGhOWuQevahRfot Yw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a38u4r0ks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jul 2021 10:16:00 -0400 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16SEFxGO152465; Wed, 28 Jul 2021 10:15:59 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a38u4r0kg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jul 2021 10:15:59 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16SEC4NW014219; Wed, 28 Jul 2021 14:15:59 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02wdc.us.ibm.com with ESMTP id 3a235mng5j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jul 2021 14:15:59 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16SEFwDD44302816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Jul 2021 14:15:59 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1061AE07E; Wed, 28 Jul 2021 14:15:58 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B21EAE066; Wed, 28 Jul 2021 14:15:56 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.85.68.146]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 28 Jul 2021 14:15:55 +0000 (GMT) X-Mailer: emacs 28.0.50 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Matthew Wilcox , Nicholas Piggin Cc: Andrew Morton , Mel Gorman , Yang Shi , linux-mm@kvack.org, Alexey Kardashevskiy Subject: Re: [PATCH] mm/migrate: fix page state accounting type conversion underflow In-Reply-To: References: <20210722054840.501423-1-npiggin@gmail.com> Date: Wed, 28 Jul 2021 19:45:53 +0530 Message-ID: <87mtq6ttgm.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1vUe07xHm_YZc3nwaNFGKK-rNzDRXqK_ X-Proofpoint-ORIG-GUID: IHTKYgE3LmlRVDXUDT6b-mad1pNwxc0L X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-28_08:2021-07-27,2021-07-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1011 mlxscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107280079 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=agSeZo5H; spf=pass (imf27.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspamd-Server: rspam02 X-Stat-Signature: xq9kg31ppqo3nosj9dgtjs9moct6zxpw X-Rspamd-Queue-Id: 0F1907002742 X-HE-Tag: 1627481774-493650 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > This patch is insufficient ... mem_cgroup_move_account() has the same bug. Do we have similar issue mem_cgroup_move_account()? void __mod_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, int val) { /* Update node */ __mod_node_page_state(lruvec_pgdat(lruvec), idx, val); the int val -> long val update happens as expected right? -aneesh