From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4C2C4361B for ; Tue, 8 Dec 2020 08:13:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1367323A51 for ; Tue, 8 Dec 2020 08:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1367323A51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2BAB86B005C; Tue, 8 Dec 2020 03:13:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26A866B005D; Tue, 8 Dec 2020 03:13:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181C46B0068; Tue, 8 Dec 2020 03:13:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id F3F496B005C for ; Tue, 8 Dec 2020 03:13:28 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B13C81EE6 for ; Tue, 8 Dec 2020 08:13:28 +0000 (UTC) X-FDA: 77569400496.29.smell87_0d0a536273e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 93BE7180868E4 for ; Tue, 8 Dec 2020 08:13:28 +0000 (UTC) X-HE-Tag: smell87_0d0a536273e5 X-Filterd-Recvd-Size: 3749 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 08:13:27 +0000 (UTC) IronPort-SDR: 4yKrP3ixArK2H2tx/0Vbj42VFBtg7c/rSGrCGbU0rtwzVgopdGFFrf15IGi2AK2yWRTN3OoM8u 6TvsZ21cAeLA== X-IronPort-AV: E=McAfee;i="6000,8403,9828"; a="161616100" X-IronPort-AV: E=Sophos;i="5.78,401,1599548400"; d="scan'208";a="161616100" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 00:13:25 -0800 IronPort-SDR: W21BXtgwhhJqh+/qdeSS/3WKv+CiAmn3UztY0E5NznK4F5IQp/0FBnhhz1akokPWaRXmY3rbar 3l7G0TZzFk+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,401,1599548400"; d="scan'208";a="317693850" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.50]) by fmsmga008.fm.intel.com with ESMTP; 08 Dec 2020 00:13:22 -0800 From: "Huang\, Ying" To: "Alejandro Colomar \(mailing lists\; readonly\)" Cc: Peter Zijlstra , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Matthew Wilcox \(Oracle\)" , Rafael Aquini , Andrew Morton , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes , linux-api@vger.kernel.org Subject: Re: [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING References: <20201202084234.15797-1-ying.huang@intel.com> <20201202084234.15797-3-ying.huang@intel.com> <48e758d7-9961-e28e-26f5-3bb381d36309@gmail.com> Date: Tue, 08 Dec 2020 16:13:21 +0800 In-Reply-To: <48e758d7-9961-e28e-26f5-3bb381d36309@gmail.com> (Alejandro Colomar's message of "Wed, 2 Dec 2020 13:33:13 +0100") Message-ID: <87pn3klnq6.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Alex, Sorry for late, I just notice this email today. "Alejandro Colomar (mailing lists; readonly)" writes: > Hi Huang Ying, > > Please see a few fixes below. > > Michael, as always, some question for you too ;) > > Thanks, > > Alex > > On 12/2/20 9:42 AM, Huang Ying wrote: >> Signed-off-by: "Huang, Ying" >> --- >> man2/set_mempolicy.2 | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 >> index 68011eecb..3754b3e12 100644 >> --- a/man2/set_mempolicy.2 >> +++ b/man2/set_mempolicy.2 >> @@ -113,6 +113,12 @@ A nonempty >> .I nodemask >> specifies node IDs that are relative to the set of >> node IDs allowed by the process's current cpuset. >> +.TP >> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)" > > I'd prefer it to be in alphabetical order (rather than just adding at > the bottom). That's OK for me. But it's better to be done in another patch to distinguish contents from pure order change? > That way, when lists grow, it's easier to find things. > >> +Enable the Linux kernel NUMA balancing for the task if it is supported >> +by kernel. > > I'd s/Linux kernel/kernel/ when it doesn't specifically refer to the > Linux kernel to differentiate it from other kernels. It only adds noise > (IMHO). mtk? Sure. Will fix this and all following comments below. Thanks a lot for your help! I am new to man pages. Best Regards, Huang, Ying