From: Thomas Gleixner <tglx@linutronix.de>
To: Song Liu <song@kernel.org>,
linux-mm@kvack.org, bpf@vger.kernel.org, netdev@vger.kernel.org,
x86@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kernel-team@fb.com, akpm@linux-foundation.org,
pmenzel@molgen.mpg.de, rick.p.edgecombe@intel.com,
Song Liu <song@kernel.org>
Subject: Re: [PATCH bpf 4/4] bpf: use __vmalloc_node_range() with VM_TRY_HUGE_VMAP for bpf_prog_pack
Date: Thu, 31 Mar 2022 02:00:08 +0200 [thread overview]
Message-ID: <87r16jm1o7.ffs@tglx> (raw)
In-Reply-To: <20220330225642.1163897-5-song@kernel.org>
On Wed, Mar 30 2022 at 15:56, Song Liu wrote:
> We cannot yet savely enable HAVE_ARCH_HUGE_VMAP for all vmalloc in X86_64.
> Let bpf_prog_pack to call __vmalloc_node_range() with VM_TRY_HUGE_VMAP
> directly.
Again, this changelog lacks any form of reasoning and justification.
Aside of that there is absolutely nothing x86_64 specific in the patch.
You might know all the details behind this change today, but will you be
able to make sense of the above half a year from now?
Even if you can, then anyone else is left in the dark.
Thanks,
tglx
next prev parent reply other threads:[~2022-03-31 0:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 22:56 [PATCH bpf 0/4] introduce HAVE_ARCH_HUGE_VMALLOC_FLAG for bpf_prog_pack Song Liu
2022-03-30 22:56 ` [PATCH bpf 1/4] x86: disable HAVE_ARCH_HUGE_VMALLOC Song Liu
2022-03-30 23:47 ` Thomas Gleixner
2022-03-30 22:56 ` [PATCH bpf 2/4] vmalloc: introduce HAVE_ARCH_HUGE_VMALLOC_FLAG Song Liu
2022-03-30 23:40 ` Edgecombe, Rick P
2022-03-31 0:26 ` Song Liu
2022-03-30 22:56 ` [PATCH bpf 3/4] x86: select HAVE_ARCH_HUGE_VMALLOC_FLAG for X86_64 Song Liu
2022-03-30 23:54 ` Thomas Gleixner
2022-03-31 0:30 ` Song Liu
2022-03-30 22:56 ` [PATCH bpf 4/4] bpf: use __vmalloc_node_range() with VM_TRY_HUGE_VMAP for bpf_prog_pack Song Liu
2022-03-31 0:00 ` Thomas Gleixner [this message]
2022-03-31 0:31 ` Song Liu
2022-03-31 0:04 ` [PATCH bpf 0/4] introduce HAVE_ARCH_HUGE_VMALLOC_FLAG " Edgecombe, Rick P
2022-03-31 0:46 ` Song Liu
2022-03-31 16:19 ` Edgecombe, Rick P
2022-03-31 5:37 ` Christoph Hellwig
2022-03-31 23:59 ` Song Liu
2022-04-01 22:22 ` Song Liu
2022-04-05 7:07 ` Christoph Hellwig
2022-04-05 23:54 ` Song Liu
2022-04-07 19:57 ` Song Liu
2022-04-08 10:08 ` Claudio Imbrenda
2022-04-08 21:22 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16jm1o7.ffs@tglx \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).