From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FC1C433EF for ; Thu, 31 Mar 2022 00:00:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 650246B0072; Wed, 30 Mar 2022 20:00:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 600586B0073; Wed, 30 Mar 2022 20:00:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EE728D0001; Wed, 30 Mar 2022 20:00:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 42B686B0072 for ; Wed, 30 Mar 2022 20:00:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0F1B420A1E for ; Thu, 31 Mar 2022 00:00:12 +0000 (UTC) X-FDA: 79302723864.02.FC56511 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 79B3C1C0014 for ; Thu, 31 Mar 2022 00:00:11 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1648684809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f93RugVHUQxMTA0bnAiY2VXHeWwPqVsL/byJ9IrZ/Fs=; b=AivTVFEfanb+t+GwmoRKdZ5Pz7jzlMOVPEHevctk4u6L7N16uVvv/FraI/2/gzVekImI1m x/p61Z5aP+lYfddmSCOC2z/WSNMyc9AVxZzR2oY9C/8pm8/Ngc8NnIgPLMbuCgibOLVwlz UlWImsvXOu/c7sXqKjXh5HgRNnjY6udf+AkkupHjR0OwzAkzVRJqYfdGFJIF0lZaGXhDCJ stte417LttX2UtVlmuk227nSQyc8y5DSWzUvQHV+jWBuVSpKWIFveFmxDDcnF83Nr5oljS r3hYkLLJ/s9NJwLkgvl3LdD4d8e/b9lfmB+CB0W/usVIEWgLZ8xM1o9i0Zidag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1648684809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f93RugVHUQxMTA0bnAiY2VXHeWwPqVsL/byJ9IrZ/Fs=; b=U1u9bIQ+ZcS125XgnB5eKfxxk+keScRqsmuBo0Q2IDgMQKZWPvGwVZhB0FB1OIXYzMRj1Y Z0vipFmo+xyjuFBA== To: Song Liu , linux-mm@kvack.org, bpf@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kernel-team@fb.com, akpm@linux-foundation.org, pmenzel@molgen.mpg.de, rick.p.edgecombe@intel.com, Song Liu Subject: Re: [PATCH bpf 4/4] bpf: use __vmalloc_node_range() with VM_TRY_HUGE_VMAP for bpf_prog_pack In-Reply-To: <20220330225642.1163897-5-song@kernel.org> References: <20220330225642.1163897-1-song@kernel.org> <20220330225642.1163897-5-song@kernel.org> Date: Thu, 31 Mar 2022 02:00:08 +0200 Message-ID: <87r16jm1o7.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Stat-Signature: mqoj97imjxnj9y1onjruepi6dt19osed Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=AivTVFEf; dkim=pass header.d=linutronix.de header.s=2020e header.b=U1u9bIQ+; spf=pass (imf18.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 79B3C1C0014 X-HE-Tag: 1648684811-984497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 30 2022 at 15:56, Song Liu wrote: > We cannot yet savely enable HAVE_ARCH_HUGE_VMAP for all vmalloc in X86_64. > Let bpf_prog_pack to call __vmalloc_node_range() with VM_TRY_HUGE_VMAP > directly. Again, this changelog lacks any form of reasoning and justification. Aside of that there is absolutely nothing x86_64 specific in the patch. You might know all the details behind this change today, but will you be able to make sense of the above half a year from now? Even if you can, then anyone else is left in the dark. Thanks, tglx