From: "Huang\, Ying" <ying.huang@intel.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <tim.c.chen@linux.intel.com>
Subject: Re: [Patch v2 1/3] mm/swapfile.c: found_free could be represented by (tmp < max)
Date: Wed, 22 Apr 2020 08:36:01 +0800 [thread overview]
Message-ID: <87r1wgqrv2.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20200421213824.8099-1-richard.weiyang@gmail.com> (Wei Yang's message of "Tue, 21 Apr 2020 21:38:22 +0000")
Wei Yang <richard.weiyang@gmail.com> writes:
> This is not necessary to use the variable found_free to record the
> status. Just check tmp and max is enough.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
All 3 patches looks good to me. Thanks!
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Best Regards,
Huang, Ying
> ---
> mm/swapfile.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 469ab417ed43..d203cdc6750a 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -601,7 +601,6 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si,
> {
> struct percpu_cluster *cluster;
> struct swap_cluster_info *ci;
> - bool found_free;
> unsigned long tmp, max;
>
> new_cluster:
> @@ -623,8 +622,6 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si,
> return false;
> }
>
> - found_free = false;
> -
> /*
> * Other CPUs can use our cluster if they can't find a free cluster,
> * check if there is still free entry in the cluster
> @@ -638,21 +635,19 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si,
> }
> ci = lock_cluster(si, tmp);
> while (tmp < max) {
> - if (!si->swap_map[tmp]) {
> - found_free = true;
> + if (!si->swap_map[tmp])
> break;
> - }
> tmp++;
> }
> unlock_cluster(ci);
> - if (!found_free) {
> + if (tmp >= max) {
> cluster_set_null(&cluster->index);
> goto new_cluster;
> }
> cluster->next = tmp + 1;
> *offset = tmp;
> *scan_base = tmp;
> - return found_free;
> + return tmp < max;
> }
>
> static void __del_from_avail_list(struct swap_info_struct *p)
prev parent reply other threads:[~2020-04-22 0:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 21:38 [Patch v2 1/3] mm/swapfile.c: found_free could be represented by (tmp < max) Wei Yang
2020-04-21 21:38 ` [Patch v2 2/3] mm/swapfile.c: tmp is always smaller than max Wei Yang
2020-04-21 21:38 ` [Patch v2 3/3] mm/swapfile.c: omit a duplicate code by compare tmp and max first Wei Yang
2020-04-22 0:36 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1wgqrv2.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).