From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15A1C33C9A for ; Tue, 3 Dec 2019 23:06:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 622A12084F for ; Tue, 3 Dec 2019 23:06:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=axtens.net header.i=@axtens.net header.b="PW2Wkfux" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 622A12084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1CCF6B0765; Tue, 3 Dec 2019 18:06:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCC086B0766; Tue, 3 Dec 2019 18:06:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE2606B0767; Tue, 3 Dec 2019 18:06:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98A496B0765 for ; Tue, 3 Dec 2019 18:06:31 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 40838181AEF0B for ; Tue, 3 Dec 2019 23:06:31 +0000 (UTC) X-FDA: 76225366182.09.cats71_38de7f194735f X-HE-Tag: cats71_38de7f194735f X-Filterd-Recvd-Size: 4047 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 23:06:30 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id h13so2300459plr.1 for ; Tue, 03 Dec 2019 15:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=bXy7NM8OEylzILS3IOTUoMYUvMeJ9d2TpmEppzXg138=; b=PW2WkfuxIy1JFpiBzmDQG0qWYyh/qUosWB3bQNykF3sMjMidB7p+Mr0+c2HwFdDgCe WyHML8KbjNW76G60r6Ftn1KFBcyRJthYYb4zKCrfAoyjjtjJC2LnIeof24prkUmg9Zvm xJ9DJllAeYNXoQQ4rWvRSuWNdnYlNhs69nVX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=bXy7NM8OEylzILS3IOTUoMYUvMeJ9d2TpmEppzXg138=; b=J5Av6T17Zr4Dn3BNTCXGHk0U9zOVeognuPoYF6eThCDvCl51GRdU0carlaC02IQV/j RCVEtd8I29i3/d60/eOmaIXRJLsVJGgXF0ZSZNjo4WBVcX+B8DO8RDHVDAsGlLICAVLM Z42rSnB5GDc+CCXKtlSr3VcUmGxqJVbI+lV985xNXy0ASBaF56h0iR/+OdCjYKh0RjEq Mf69DarDCpZBxbcvXtjK2e5rsM2QOpaFsHsAnUTetlK4lpFwAKpnsHU2tHQu+ycxzF+i ikY6kvNKvZ+YO6/vlEU9fumKyIGZjvy+GCfF81WiE3311Q5VLUDYRwgfGOV+J/Uh8PLZ ZcHQ== X-Gm-Message-State: APjAAAULQ2ItDXs12UtF1JniAk/hO7fwMlsPFAyEWokx2CUZcp2HSWpa ka4qhvRGM7I0qzv/y2DIBMpy3w== X-Google-Smtp-Source: APXvYqyqAUHXHZMEyAtkFIhrnt1qDaygo71ykt0xMa0br5Gxl9V33x73Jj+ukiYG/iFVISwtXt23rA== X-Received: by 2002:a17:902:9891:: with SMTP id s17mr396741plp.101.1575414389447; Tue, 03 Dec 2019 15:06:29 -0800 (PST) Received: from localhost (2001-44b8-1113-6700-7daa-d2ea-7edb-cfe8.static.ipv6.internode.on.net. [2001:44b8:1113:6700:7daa:d2ea:7edb:cfe8]) by smtp.gmail.com with ESMTPSA id b7sm4006998pjo.3.2019.12.03.15.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 15:06:28 -0800 (PST) From: Daniel Axtens To: zhong jiang , akpm@linux-foundation.org Cc: aryabinin@virtuozzo.com, glider@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/kasan: Fix an compile error In-Reply-To: <1575363013-43761-1-git-send-email-zhongjiang@huawei.com> References: <1575363013-43761-1-git-send-email-zhongjiang@huawei.com> Date: Wed, 04 Dec 2019 10:06:25 +1100 Message-ID: <87sgm1dn66.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Thanks, I see that Andrew has already picked this up, but for what it's worth: Reviewed-by: Daniel Axtens Regards, Daniel > I hit the following compile error in arch/x86/ > > mm/kasan/common.c: In function kasan_populate_vmalloc: > mm/kasan/common.c:797:2: error: implicit declaration of function flush_cache_vmap; did you mean flush_rcu_work? [-Werror=implicit-function-declaration] > flush_cache_vmap(shadow_start, shadow_end); > ^~~~~~~~~~~~~~~~ > flush_rcu_work > cc1: some warnings being treated as errors > make[2]: *** [mm/kasan/common.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [mm/kasan] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [mm] Error 2 > make: *** Waiting for unfinished jobs.... > > Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory") > Signed-off-by: zhong jiang > --- > mm/kasan/common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index df3371d..2fa710b 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -36,6 +36,7 @@ > #include > #include > > +#include > #include > > #include "kasan.h" > -- > 1.7.12.4