From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D474C4332F for ; Tue, 22 Nov 2022 16:52:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A06996B0071; Tue, 22 Nov 2022 11:52:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B66B6B0073; Tue, 22 Nov 2022 11:52:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A5B36B0074; Tue, 22 Nov 2022 11:52:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7C05F6B0071 for ; Tue, 22 Nov 2022 11:52:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1083C14113E for ; Tue, 22 Nov 2022 16:52:14 +0000 (UTC) X-FDA: 80161670988.12.418F0E7 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 55641C0012 for ; Tue, 22 Nov 2022 16:52:13 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669135931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gjmtC/V1IhUMDwLItEi+YzLakaX5z0D3glhq5KpL7n0=; b=zL+JREAI54DPIOaCj7r+99hl6Omzz5yTQz4rB9mo3oM7+z4ImloQlObcg3mAH/wze1pnFQ Mmt4JKu+KPW9dipD0w5t1oF6L1V/T0tEhOdglZGMY9coDNGWiHcPXgfuFobe8FZIGuaoJ4 hP9ekFK+RjoBZUImHvClct4h2x4yIekFNv6WEtyeVch04auNBVV1Lu6cSSYz1w+AODwCpf 7jH9pS9ooKPmdsLU3y8wQ0tD6KDkCt3+ATiUGnL+IG8oiLHhuItTFpKa616Xh56OhYJRWF n0XjIs4x55yh0cTX3s/QLbCgqKNsGiCUtVRbTN6YC5GFzxAcJpkMuZtHGYaWMA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669135931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gjmtC/V1IhUMDwLItEi+YzLakaX5z0D3glhq5KpL7n0=; b=GbdranQm66ucsOgjrVBBcyt+6Dk3M9qsLoUxUwsiqJSGRQ2y9sZuwXT1O7MXzbIvtgudCs WemgrRenS68AWwDw== To: Dave Hansen , Peter Zijlstra , Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v7 06/20] x86/virt/tdx: Shut down TDX module in case of error In-Reply-To: <058a6033-a5e0-771b-3c16-950fdbb8c1e5@intel.com> References: <48505089b645019a734d85c2c29f3c8ae2dbd6bd.1668988357.git.kai.huang@intel.com> <058a6033-a5e0-771b-3c16-950fdbb8c1e5@intel.com> Date: Tue, 22 Nov 2022 17:52:10 +0100 Message-ID: <87tu2rextx.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669135933; a=rsa-sha256; cv=none; b=jOe5KzbkhLKlMpsnRI+zIxe3A4+Hd3CPOJQ8HA7b4xo3lfPLv1Uu8JVL5/Dk2k+S6QEvtd PPfBDE0BQzUknsH4OQFTMoYFpHD9blYOSa0eoVrR8hqke8+l0lVaBlGtKqPe/+wNRqF760 GasF4+P3hBs4qgz32vFMgHPlmLM8aP0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=zL+JREAI; dkim=pass header.d=linutronix.de header.s=2020e header.b=GbdranQm; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf10.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669135933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gjmtC/V1IhUMDwLItEi+YzLakaX5z0D3glhq5KpL7n0=; b=E/dQ4k9qox0XaZsoFAjDmLmR1/ms0CY6ZP7vXib/OnDXf5GGOqTXgCxcmNxGF4dmRrVZXc AsVGb9pzYJ7wbB5Ld+fEpnEIXVClSrlPIXUa6eQAArxRVLzV5oWu9rb5XYaaOIxwxEQdpT Q8lyLMTHQ4uUEf0jIFpaWKq14y5r7Sc= X-Stat-Signature: r3p1pib9x7pezbq13jk6e5pdofrhaky1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 55641C0012 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=zL+JREAI; dkim=pass header.d=linutronix.de header.s=2020e header.b=GbdranQm; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf10.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de X-Rspam-User: X-HE-Tag: 1669135933-142612 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000142, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22 2022 at 07:20, Dave Hansen wrote: > On 11/22/22 01:20, Peter Zijlstra wrote: >> Either the Changelog is broken or this TDX crud is worse crap than I >> thought possible, because the only way to actually meet that requirement >> as stated is stop_machine(). > > I think the changelog is broken. I don't see anything in the TDX module > spec about "the SEMACALL can run concurrently on different CPUs". > Shutdown, as far as I can tell, just requires that the shutdown seamcall > be run once on each CPU. Concurrency and ordering don't seem to matter > at all. You're right. The 'can concurrently run' thing is for LP.INIT: 4.2.2. LP-Scope Initialization: TDH.SYS.LP.INIT TDH.SYS.LP.INIT is intended to perform LP-scope, core-scope and package-scope initialization of the Intel TDX module. It can be called only after TDH.SYS.INIT completes successfully, and it can run concurrently on multiple LPs.