From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B25C433EF for ; Wed, 22 Sep 2021 02:07:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B2E7860F4C for ; Wed, 22 Sep 2021 02:07:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2E7860F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B5F3B6B006C; Tue, 21 Sep 2021 22:07:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE5C16B0072; Tue, 21 Sep 2021 22:07:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 961EA6B0073; Tue, 21 Sep 2021 22:07:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 7F4D06B006C for ; Tue, 21 Sep 2021 22:07:18 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1CB3B2FD81 for ; Wed, 22 Sep 2021 02:07:18 +0000 (UTC) X-FDA: 78613572156.35.419C21E Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf27.hostedemail.com (Postfix) with ESMTP id C2F3470000A8 for ; Wed, 22 Sep 2021 02:07:16 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="223145924" X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="223145924" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 19:07:15 -0700 X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="474388035" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 19:07:12 -0700 From: "Huang, Ying" To: John Hubbard Cc: Weizhao Ouyang , Andrew Morton , , , Anshuman Khandual , Michal Hocko , Pavel Tatashin , Yang Shi , Zi Yan , Dave Hansen , Minchan Kim , Mina Almasry , "Matthew Wilcox (Oracle)" , Oscar Salvador , Wei Xu Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names References: <20210921064553.293905-1-o451686892@gmail.com> <20210921064553.293905-3-o451686892@gmail.com> <87mto676fq.fsf@yhuang6-desk2.ccr.corp.intel.com> <87ee9i6n1w.fsf@yhuang6-desk2.ccr.corp.intel.com> <384b551e-28f0-ca7a-61b5-78f238de6e4d@nvidia.com> Date: Wed, 22 Sep 2021 10:07:10 +0800 In-Reply-To: <384b551e-28f0-ca7a-61b5-78f238de6e4d@nvidia.com> (John Hubbard's message of "Tue, 21 Sep 2021 11:00:04 -0700") Message-ID: <87y27p5po1.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C2F3470000A8 Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf27.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=ying.huang@intel.com X-Stat-Signature: pdkobxwwcrz97amjqf4kcqisbx8pzfmy X-HE-Tag: 1632276436-906065 X-Bogosity: Ham, tests=bogofilter, spamicity=0.014525, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: John Hubbard writes: > On 9/21/21 07:06, Huang, Ying wrote: > ... >>>> Can we add BUILD_BUG_ON() somewhere to capture at least some >>>> synchronization issue? >>> >>> Hi Huang, we discussed this in the v1 thread with you and John, seems you >>> missed it. Now we just add a comment to do the synchronization, and we can >>> figure out a more general way to use strings which in trace_events straight. >> Got it! And I think we can add the BUILD_BUG_ON() now and delete it >> when we have a better solution to deal with that. But if you can work >> out a better solution quickly, that's fine to ignore this. >> > > I have a solution now, it's basically what I sent earlier. There appears to be > some confusion about it. I'll send it out as a patch that builds on top of > these two, hopefully in a few hours, if no problems pop up during testing. Sorry, I didn't read your latest email. The solution looks good! Thanks! Best Regards, Huang, Ying