From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172C3C433E9 for ; Mon, 1 Mar 2021 21:20:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9619F60232 for ; Mon, 1 Mar 2021 21:20:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9619F60232 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lwn.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35EE68D00A4; Mon, 1 Mar 2021 16:20:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30D198D0063; Mon, 1 Mar 2021 16:20:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 222E58D00A4; Mon, 1 Mar 2021 16:20:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 053968D0063 for ; Mon, 1 Mar 2021 16:20:15 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8C33D181AF5D0 for ; Mon, 1 Mar 2021 21:20:14 +0000 (UTC) X-FDA: 77872573548.08.9652C27 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 8F782E19FFF9 for ; Mon, 1 Mar 2021 21:20:03 +0000 (UTC) Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 4F0962B8; Mon, 1 Mar 2021 21:20:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 4F0962B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1614633606; bh=l4qaMOIFJPi87PZtng+nOYR5Z8yYgHYIN56dlYv4y+E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KzsfCvaL4KuFXej/+GVa/PnctspANHhOdRj1YF3HJfEEWxMFe3DxDVfOrj3vqWiYk wDRk9qSWa13AibLeew2AYJgz9Rd9ZeL7C5Js6w9pdhw9md1z6n1atEfM8ddmYZJVPT KEiu0YJ7PygLixmXnYo2DmqxIpEqpuVlr45ktmSIrhQeR3MYkNIC5F93xqOyJVEF7e X1OEd5nZ0CwGV1pXWEUS6669AkDjZ6Rk0N69C047NV9C/c6Qkmjt+Vj9aFG/B05TJD PljtIXpwPphQND0la+2/kABwbR+7u/IZEujQeLqtHC9CQ2PfMJGjz4tfHdsv//xe8I gWG/ebqfZKbsw== From: Jonathan Corbet To: Yang Shi , hannes@cmpxchg.org, mhocko@suse.com, guro@fb.com, shakeelb@google.com, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: memcontrol: add description for oom_kill In-Reply-To: <20210226021254.3980-1-shy828301@gmail.com> References: <20210226021254.3980-1-shy828301@gmail.com> Date: Mon, 01 Mar 2021 14:20:05 -0700 Message-ID: <87y2f63722.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: 37zjsnxobuhafg48uwufc7xb63qno5s1 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8F782E19FFF9 Received-SPF: none (lwn.net>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=ms.lwn.net; client-ip=45.79.88.28 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614633603-289741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yang Shi writes: > When debugging an oom issue, I found the oom_kill counter of memcg is > confusing. At the first glance without checking document, I thought it > just counts for memcg oom, but it turns out it counts both global and > memcg oom. > > The cgroup v2 documents it, but the description is missed for cgroup v1. > > Signed-off-by: Yang Shi > --- > Documentation/admin-guide/cgroup-v1/memory.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst > index 0936412e044e..44d5429636e2 100644 > --- a/Documentation/admin-guide/cgroup-v1/memory.rst > +++ b/Documentation/admin-guide/cgroup-v1/memory.rst > @@ -851,6 +851,9 @@ At reading, current status of OOM is shown. > (if 1, oom-killer is disabled) > - under_oom 0 or 1 > (if 1, the memory cgroup is under OOM, tasks may be stopped.) > + - oom_kill integer counter > + The number of processes belonging to this cgroup killed by any > + kind of OOM killer. Applied, thanks. jon