From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23273C282DD for ; Fri, 10 Jan 2020 17:39:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D643C2087F for ; Fri, 10 Jan 2020 17:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D643C2087F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 77BBB8E0005; Fri, 10 Jan 2020 12:39:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 704F08E0001; Fri, 10 Jan 2020 12:39:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CD268E0005; Fri, 10 Jan 2020 12:39:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 41DE18E0001 for ; Fri, 10 Jan 2020 12:39:10 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 00DE9824934B for ; Fri, 10 Jan 2020 17:39:10 +0000 (UTC) X-FDA: 76362435660.25.geese42_8a23a717e5c36 X-HE-Tag: geese42_8a23a717e5c36 X-Filterd-Recvd-Size: 8034 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jan 2020 17:39:09 +0000 (UTC) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00AHXAMf034354; Fri, 10 Jan 2020 12:39:04 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xemacjcup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jan 2020 12:39:03 -0500 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 00AHd3FU085853; Fri, 10 Jan 2020 12:39:03 -0500 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xemacjcu7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jan 2020 12:39:03 -0500 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 00AHcZCU005453; Fri, 10 Jan 2020 17:39:02 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma04dal.us.ibm.com with ESMTP id 2xajb7pqb5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jan 2020 17:39:02 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 00AHd1LY22020566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jan 2020 17:39:01 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3CC23124053; Fri, 10 Jan 2020 17:39:01 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3FB3B124052; Fri, 10 Jan 2020 17:38:56 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.199.36.244]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 10 Jan 2020 17:38:55 +0000 (GMT) X-Mailer: emacs 26.3 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Sandipan Das , shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: linux-arch@vger.kernel.org, fweimer@redhat.com, dave.hansen@intel.com, x86@kernel.org, linuxram@us.ibm.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, bauerman@linux.ibm.com, msuchanek@suse.de, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Subject: Re: [PATCH v15 00/24] selftests, powerpc, x86: Memory Protection Keys In-Reply-To: References: Date: Fri, 10 Jan 2020 23:08:53 +0530 Message-ID: <87y2ufxlci.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-01-10_01:2020-01-10,2020-01-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1011 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001100142 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sandipan Das writes: > Memory protection keys enables an application to protect its address > space from inadvertent access by its own code. > > This feature is now enabled on powerpc and has been available since > 4.16-rc1. The patches move the selftests to arch neutral directory > and enhance their test coverage. > > Testing > ------- > Verified for correctness on powerpc. Need help with x86 testing as I > do not have access to a Skylake server. Client platforms like Coffee > Lake do not have the required feature bits set in CPUID. > > Changelog > --------- > Link to previous version (v14): > https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=55981&state=* > > v15: > (1) Rebased on top of latest master. > (2) Addressed review comments from Dave Hansen. > (3) Moved code for getting or setting pkey bits to new > helpers. These changes replace patch 7 of v14. > (4) Added a fix which ensures that the correct count of > reserved keys is used across different platforms. > (5) Added a fix which ensures that the correct page size > is used as powerpc supports both 4K and 64K pages. > Any update on merging this series? Can Intel help with testing this series on Skylake server? Possibly merging to -next will result in automated 01.org tests? > v14: > (1) Incorporated another round of comments from Dave Hansen. > > v13: > (1) Incorporated comments for Dave Hansen. > (2) Added one more test for correct pkey-0 behavior. > > v12: > (1) Fixed the offset of pkey field in the siginfo structure for > x86_64 and powerpc. And tries to use the actual field > if the headers have it defined. > > v11: > (1) Fixed a deadlock in the ptrace testcase. > > v10 and prior: > (1) Moved the testcase to arch neutral directory. > (2) Split the changes into incremental patches. > > Desnes A. Nunes do Rosario (1): > selftests/vm/pkeys: Fix number of reserved powerpc pkeys > > Ram Pai (17): > selftests/x86/pkeys: Move selftests to arch-neutral directory > selftests/vm/pkeys: Rename all references to pkru to a generic name > selftests/vm/pkeys: Move generic definitions to header file > selftests/vm/pkeys: Typecast the pkey register > selftests/vm/pkeys: Fix pkey_disable_clear() > selftests/vm/pkeys: Fix assertion in pkey_disable_set/clear() > selftests/vm/pkeys: Fix alloc_random_pkey() to make it really random > selftests/vm/pkeys: Introduce generic pkey abstractions > selftests/vm/pkeys: Introduce powerpc support > selftests/vm/pkeys: Fix assertion in test_pkey_alloc_exhaust() > selftests/vm/pkeys: Improve checks to determine pkey support > selftests/vm/pkeys: Associate key on a mapped page and detect access > violation > selftests/vm/pkeys: Associate key on a mapped page and detect write > violation > selftests/vm/pkeys: Detect write violation on a mapped > access-denied-key page > selftests/vm/pkeys: Introduce a sub-page allocator > selftests/vm/pkeys: Test correct behaviour of pkey-0 > selftests/vm/pkeys: Override access right definitions on powerpc > > Sandipan Das (3): > selftests: vm: pkeys: Add helpers for pkey bits > selftests: vm: pkeys: Use the correct huge page size > selftests: vm: pkeys: Use the correct page size on powerpc > > Thiago Jung Bauermann (2): > selftests/vm/pkeys: Move some definitions to arch-specific header > selftests/vm/pkeys: Make gcc check arguments of sigsafe_printf() > > tools/testing/selftests/vm/.gitignore | 1 + > tools/testing/selftests/vm/Makefile | 5 + > tools/testing/selftests/vm/pkey-helpers.h | 226 ++++++ > tools/testing/selftests/vm/pkey-powerpc.h | 138 ++++ > tools/testing/selftests/vm/pkey-x86.h | 183 +++++ > .../selftests/{x86 => vm}/protection_keys.c | 688 ++++++++++-------- > tools/testing/selftests/x86/.gitignore | 1 - > tools/testing/selftests/x86/pkey-helpers.h | 219 ------ > 8 files changed, 931 insertions(+), 530 deletions(-) > create mode 100644 tools/testing/selftests/vm/pkey-helpers.h > create mode 100644 tools/testing/selftests/vm/pkey-powerpc.h > create mode 100644 tools/testing/selftests/vm/pkey-x86.h > rename tools/testing/selftests/{x86 => vm}/protection_keys.c (74%) > delete mode 100644 tools/testing/selftests/x86/pkey-helpers.h > > -- > 2.17.1 -aneesh