From: "Huang, Ying" <ying.huang@intel.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Zi Yan <ziy@nvidia.com>, Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH -V2 1/7] migrate: fix syscall move_pages() return value for failure
Date: Tue, 12 Jul 2022 08:59:12 +0800 [thread overview]
Message-ID: <87zghf5eov.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <YswPApwvAjvX1VEd@localhost.localdomain> (Oscar Salvador's message of "Mon, 11 Jul 2022 13:52:34 +0200")
Oscar Salvador <osalvador@suse.de> writes:
> On Mon, Jul 11, 2022 at 04:49:42PM +0800, Huang Ying wrote:
>> return store_status(status, start, node, i - start);
>> @@ -1768,8 +1768,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>>
>> err = move_pages_and_store_status(mm, current_node, &pagelist,
>> status, start, i, nr_pages);
>> - if (err)
>> + if (err) {
>> + /* We have stored status of page i */
>
> IMHO, "We have accounted for page i" gives a more clear statement.
Sure. Will change this.
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
Thanks!
Best Regards,
Huang, Ying
>> + if (err > 0)
>> + err--;
>> goto out;
>> + }
>> current_node = NUMA_NO_NODE;
>> }
>> out_flush:
>> --
>> 2.30.2
>>
>>
next prev parent reply other threads:[~2022-07-12 0:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 8:49 [PATCH -V2 0/7] migrate_pages(): fix several bugs in error path Huang Ying
2022-07-11 8:49 ` [PATCH -V2 1/7] migrate: fix syscall move_pages() return value for failure Huang Ying
2022-07-11 11:52 ` Oscar Salvador
2022-07-12 0:59 ` Huang, Ying [this message]
2022-07-11 8:49 ` [PATCH -V2 2/7] migrate_pages(): remove unnecessary list_safe_reset_next() Huang Ying
2022-07-11 11:57 ` Oscar Salvador
2022-07-11 8:49 ` [PATCH -V2 3/7] migrate_pages(): fix THP failure counting for -ENOMEM Huang Ying
2022-07-11 12:01 ` Oscar Salvador
2022-07-11 8:49 ` [PATCH -V2 4/7] migrate_pages(): fix failure counting for THP subpages retrying Huang Ying
2022-07-11 12:13 ` Oscar Salvador
2022-07-11 8:49 ` [PATCH -V2 5/7] migrate_pages(): fix failure counting for THP on -ENOSYS Huang Ying
2022-07-11 12:26 ` Oscar Salvador
2022-07-13 8:30 ` Huang, Ying
2022-07-11 8:49 ` [PATCH -V2 6/7] migrate_pages(): fix failure counting for THP splitting Huang Ying
2022-07-11 12:39 ` Oscar Salvador
2022-07-11 8:49 ` [PATCH -V2 7/7] migrate_pages(): fix failure counting for retry Huang Ying
2022-07-11 12:52 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zghf5eov.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).