From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40C0C433EF for ; Wed, 27 Apr 2022 04:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 725EC6B0073; Wed, 27 Apr 2022 00:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D5AD6B0075; Wed, 27 Apr 2022 00:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54E066B0078; Wed, 27 Apr 2022 00:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 4673B6B0073 for ; Wed, 27 Apr 2022 00:34:05 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 11D9D24BBB for ; Wed, 27 Apr 2022 04:34:05 +0000 (UTC) X-FDA: 79401391650.01.3D20793 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf25.hostedemail.com (Postfix) with ESMTP id 08D8BA003F for ; Wed, 27 Apr 2022 04:33:56 +0000 (UTC) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23R2VObw015241; Wed, 27 Apr 2022 04:33:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=P/3XNVpL7lXvtlLB0wtJ1D8fNHMX45H+WNBY47qEjTU=; b=GsnU9himGDTT56UiekzH13DpKpbzyxewZCX9GAjiBcDo2LKHJ0kD3TIkIj5YL4j1gxQN VaGjE6ovtzzuot4pbLprYu9/tOtMPJvqngJTnt/wH3GUU8krFwK7LGIf1eLjYWw0ntJX zuR2TEKmEnfsiL+GzascnA8bi1Nl67hqEC0lNkBLCMZzDZZDiiEVSaiuHsPMXVFa0RFE nd+xB1uP70yVn8uqAvGVD6bQE3/FmplixT7jOKJ9RCz9I1wBBLnTRU5P3e1yQgLnY0DU gCfmoB/6VpL/cV/fWRStACN0pPMCKuqg1tWBFtCgF+UdmQ4UHJOzfyc3/JhWAIWTIG3R 9Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fpsspvpt8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 04:33:23 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 23R4LGEc013778; Wed, 27 Apr 2022 04:33:22 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fpsspvpss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 04:33:22 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23R4SXFS015709; Wed, 27 Apr 2022 04:33:20 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma02wdc.us.ibm.com with ESMTP id 3fm939srwx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 04:33:20 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23R4XJTq25035114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Apr 2022 04:33:19 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 50390C6057; Wed, 27 Apr 2022 04:33:19 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E7916C6059; Wed, 27 Apr 2022 04:33:02 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.43.50.189]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 27 Apr 2022 04:33:02 +0000 (GMT) X-Mailer: emacs 29.0.50 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Yu Zhao , Stephen Rothwell , linux-mm@kvack.org Cc: Andi Kleen , Andrew Morton , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, page-reclaim@google.com, x86@kernel.org, Yu Zhao , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?utf-8?Q?Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v10 07/14] mm: multi-gen LRU: exploit locality in rmap In-Reply-To: <20220407031525.2368067-8-yuzhao@google.com> References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-8-yuzhao@google.com> Date: Wed, 27 Apr 2022 10:02:56 +0530 Message-ID: <87zgk7xi13.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gtJPmcWjuPxlyxYBKW51oqDKp_XYDYZP X-Proofpoint-ORIG-GUID: 42FW6whtngg3Q_8U1dckC2WbPYt7lfYG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-27_01,2022-04-26_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 mlxlogscore=774 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204270028 X-Stat-Signature: ucacm4fok7demxtcw3nyhrd9b7yud97t X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 08D8BA003F Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GsnU9him; spf=pass (imf25.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspam-User: X-HE-Tag: 1651034036-357537 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yu Zhao writes: .... diff --git a/mm/rmap.c b/mm/rmap.c > index fedb82371efe..7cb7ef29088a 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -73,6 +73,7 @@ > #include > #include > #include > +#include > > #include > > @@ -821,6 +822,12 @@ static bool folio_referenced_one(struct folio *folio, > } > > if (pvmw.pte) { > + if (lru_gen_enabled() && pte_young(*pvmw.pte) && > + !(vma->vm_flags & (VM_SEQ_READ | VM_RAND_READ))) { > + lru_gen_look_around(&pvmw); > + referenced++; > + } Is it required to update referenced here? we do that below after clearing the young bit. Or is the goal to identify whether we found any young pte around? > + > if (ptep_clear_flush_young_notify(vma, address, > pvmw.pte)) { > /*