From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B321C433EF for ; Tue, 12 Apr 2022 03:29:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4F156B0071; Mon, 11 Apr 2022 23:29:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD6F76B0073; Mon, 11 Apr 2022 23:29:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C787D6B0074; Mon, 11 Apr 2022 23:29:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id B377A6B0071 for ; Mon, 11 Apr 2022 23:29:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5765C183525FD for ; Tue, 12 Apr 2022 03:29:36 +0000 (UTC) X-FDA: 79346797152.21.6EAF946 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf30.hostedemail.com (Postfix) with ESMTP id 68EDF80005 for ; Tue, 12 Apr 2022 03:29:35 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kcrl43RHYzgY8b; Tue, 12 Apr 2022 11:27:44 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 12 Apr 2022 11:29:32 +0800 Subject: Re: [PATCH 0/4] A few cleanup and fixup patches for migration To: "ying.huang@intel.com" CC: , , , , , , , , , , , , , , , , , , Andrew Morton References: <20220409073846.22286-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <880376f0-f480-979b-261f-72cf9475474c@huawei.com> Date: Tue, 12 Apr 2022 11:29:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: qa666h76esmtqb7kwbar8tna58u5iu8k Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 68EDF80005 X-HE-Tag: 1649734175-181464 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/12 10:25, ying.huang@intel.com wrote: > On Sat, 2022-04-09 at 15:38 +0800, Miaohe Lin wrote: >> Hi everyone, >> This series contains a few patches to remove unneeded lock page and >> PageMovable check, reduce the rcu lock duration. Also we fix potential >> pte_unmap on an not mapped pte. More details can be found in the >> respective changelogs. Thanks! >=20 > It appears that you ignored my comments for the previous version. Can > you check it? I do remember [1] and I tried to make isolate_huge_page consistent with i= solate_lru_page. But their return value conventions are different. isolate_huge_page retur= n 0 when success while isolate_huge_page returns true in this case. So make them c= onsistent would lead to many code change. I should have added this in my changelog. Thanks. [1] https://lore.kernel.org/linux-mm/8735jsgctq.fsf@yhuang6-desk2.ccr.cor= p.intel.com/ >=20 > Best Regards, > Huang, Ying >=20 >> --- >> v1: >> =C2=A0=C2=A0rebase [1] on mainline. >> >> [1] https://lore.kernel.org/lkml/20220304093409.25829-2-linmiaohe@huaw= ei.com/T/ >> --- >> Miaohe Lin (4): >> =C2=A0=C2=A0mm/migration: reduce the rcu lock duration >> =C2=A0=C2=A0mm/migration: remove unneeded lock page and PageMovable ch= eck >> =C2=A0=C2=A0mm/migration: return errno when isolate_huge_page failed >> =C2=A0=C2=A0mm/migration: fix potential pte_unmap on an not mapped pte >> >> =C2=A0include/linux/migrate.h | 2 +- >> =C2=A0include/linux/swapops.h | 4 ++-- >> =C2=A0mm/filemap.c | 10 +++++----- >> =C2=A0mm/hugetlb.c | 2 +- >> =C2=A0mm/migrate.c | 31 +++++++++++++------------------ >> =C2=A05 files changed, 22 insertions(+), 27 deletions(-) >> >=20 >=20 >=20 > . >=20