From: Nick Terrell <terrelln@fb.com>
To: kernel test robot <lkp@intel.com>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"Linux Memory Management List" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion
Date: Fri, 8 Oct 2021 00:09:46 +0000 [thread overview]
Message-ID: <88ACF3A0-13B2-414C-ABFA-36CDF1BCCC27@fb.com> (raw)
In-Reply-To: <20211007232743.GA59732@7c2d80b4df4a>
> On Oct 7, 2021, at 4:27 PM, kernel test robot <lkp@intel.com> wrote:
>
> Generated by: scripts/checkincludes.pl
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> debug.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/zstd/common/debug.h b/lib/zstd/common/debug.h
> index 6dd88d1fbd02c..c8dc0b1890369 100644
> --- a/lib/zstd/common/debug.h
> +++ b/lib/zstd/common/debug.h
> @@ -65,7 +65,6 @@
>
> #if (DEBUGLEVEL>=1)
> # define ZSTD_DEPS_NEED_ASSERT
> -# include "zstd_deps.h"
> #else
> # ifndef assert /* assert may be already defined, due to prior #include <assert.h> */
> # define assert(condition) ((void)0) /* disable assert (default) */
This is an intentional design choice of upstream zstd, and is correct.
Defining ZSTD_DEPS_NEED_ASSERT will cause “zstd_deps.h” to
provide a definition of assert(), even if it has already been included.
-Nick
prev parent reply other threads:[~2021-10-08 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 23:27 [linux-next:master 5414/6649] lib/zstd/common/debug.h: zstd_deps.h is included more than once kernel test robot
2021-10-07 23:27 ` [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion kernel test robot
2021-10-08 0:09 ` Nick Terrell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88ACF3A0-13B2-414C-ABFA-36CDF1BCCC27@fb.com \
--to=terrelln@fb.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).