From: Dmitry Osipenko <digetx@gmail.com>
To: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
gregkh@linuxfoundation.org, surenb@google.com,
joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org
Subject: Re: [PATCH] mm: cma: fix corruption cma_sysfs_alloc_pages_count
Date: Wed, 24 Mar 2021 22:49:58 +0300 [thread overview]
Message-ID: <89ba4c7a-42d2-5412-2367-cc1cffc1117b@gmail.com> (raw)
In-Reply-To: <18ee5c3e-fba2-0d8d-bd93-5fb8d0dd7a01@gmail.com>
24.03.2021 22:43, Dmitry Osipenko пишет:
> 24.03.2021 22:20, Minchan Kim пишет:
>> static int __init cma_sysfs_init(void)
>> {
>> - int i = 0;
>> + struct kobject *cma_kobj_root;
>> + struct cma_kobject *cma_kobj;
>> struct cma *cma;
>> + unsigned int i;
>
>> while (--i >= 0) {
>
> Do you realize that this doesn't work anymore?
>
>> cma = &cma_areas[i];
>> - kobject_put(&cma->stat->kobj);
>> - }
>>
>> - kfree(cma_stats);
>> - kobject_put(cma_kobj);
>> + kobject_put(&cma->cma_kobj->kobj);
>> + kfree(cma->cma_kobj);
>
> Freeing a null pointer?
>
>> + cma->cma_kobj = NULL;
>> + }
>> + kobject_put(cma_kobj_root);
>
Please try to simulate the errors and check that error path is working
properly in the next version.
Alternatively, we could remove the cma_kobj_release entirely, like Greg
suggested previously, and then don't care about cleaning up at all.
next prev parent reply other threads:[~2021-03-24 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 19:20 [PATCH] mm: cma: fix corruption cma_sysfs_alloc_pages_count Minchan Kim
2021-03-24 19:43 ` Dmitry Osipenko
2021-03-24 19:49 ` Minchan Kim
2021-03-24 19:49 ` Dmitry Osipenko [this message]
2021-03-24 19:57 ` Minchan Kim
2021-03-24 20:02 ` Dmitry Osipenko
2021-03-24 20:55 ` Minchan Kim
2021-03-24 19:45 ` John Hubbard
2021-03-24 19:53 ` David Hildenbrand
2021-03-24 19:55 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ba4c7a-42d2-5412-2367-cc1cffc1117b@gmail.com \
--to=digetx@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).