From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by kanga.kvack.org (Postfix) with ESMTP id 4F1056B0005 for ; Wed, 4 Jul 2018 08:22:04 -0400 (EDT) Received: by mail-ed1-f69.google.com with SMTP id c19-v6so2163169edt.4 for ; Wed, 04 Jul 2018 05:22:04 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id l59-v6si3177532edl.49.2018.07.04.05.22.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 05:22:02 -0700 (PDT) Subject: Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM References: <1530685696-14672-1-git-send-email-rppt@linux.vnet.ibm.com> <1530685696-14672-4-git-send-email-rppt@linux.vnet.ibm.com> <20180704075410.GF22503@dhcp22.suse.cz> From: Vlastimil Babka Message-ID: <89f48f7a-6cbf-ac9a-cacc-cd3ca79f8c66@suse.cz> Date: Wed, 4 Jul 2018 14:22:00 +0200 MIME-Version: 1.0 In-Reply-To: <20180704075410.GF22503@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Geert Uytterhoeven Cc: Mike Rapoport , Greg Ungerer , Sam Creasey , linux-m68k , Linux MM , Linux Kernel Mailing List On 07/04/2018 09:54 AM, Michal Hocko wrote: > On Wed 04-07-18 09:44:14, Geert Uytterhoeven wrote: > [...] >> ------------[ cut here ]------------ >> WARNING: CPU: 0 PID: 0 at mm/memblock.c:230 >> memblock_find_in_range_node+0x11c/0x1be >> memblock: bottom-up allocation failed, memory hotunplug may be affected > > This only means that hotplugable memory might contain non-movable memory > now. But does your system even support memory hotplug. I would be really > surprised. So I guess we just want this instead > diff --git a/mm/memblock.c b/mm/memblock.c > index cc16d70b8333..c0dde95593fd 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -228,7 +228,8 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size, > * so we use WARN_ONCE() here to see the stack trace if > * fail happens. > */ > - WARN_ONCE(1, "memblock: bottom-up allocation failed, memory hotunplug may be affected\n"); > + WARN_ONCE(IS_ENABLED(CONFIG_MEMORY_HOTREMOVE), > + "memblock: bottom-up allocvation failed, memory hotunplug may be affected\n"); ^ allocation ^ hotremove Makes sense, though. > } > > return __memblock_find_range_top_down(start, end, size, align, nid, >