From: Zi Yan <ziy@nvidia.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<mike.kravetz@oracle.com>, <osalvador@suse.de>, <mhocko@suse.com>,
<akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()
Date: Wed, 20 Mar 2019 22:01:58 -0700 [thread overview]
Message-ID: <8AB57711-48C0-4D95-BC5F-26B266DC3AE8@nvidia.com> (raw)
In-Reply-To: <1553141595-26907-1-git-send-email-anshuman.khandual@arm.com>
On 20 Mar 2019, at 21:13, Anshuman Khandual wrote:
> pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making
> it
> redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the
> helper
> pfn_to_online_page() which either calls pfn_valid() or
> pfn_valid_within().
> pfn_valid_within() being 1 when !CONFIG_HOLES_IN_ZONE is irrelevant
> either
> way. This does not change functionality.
>
> Fixes: 2ce13640b3f4 ("mm: __first_valid_page skip over offline pages")
I would not say this patch fixes the commit 2ce13640b3f4 from 2017,
because the pfn_valid_within() in pfn_to_online_page() was introduced by
a recent commit b13bc35193d9e last month. :)
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> mm/page_isolation.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index ce323e56b34d..d9b02bb13d60 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -150,8 +150,6 @@ __first_valid_page(unsigned long pfn, unsigned
> long nr_pages)
> for (i = 0; i < nr_pages; i++) {
> struct page *page;
>
> - if (!pfn_valid_within(pfn + i))
> - continue;
> page = pfn_to_online_page(pfn + i);
> if (!page)
> continue;
This makes sense to me. You can add Reviewed-by: Zi Yan
<ziy@nvidia.com>.
--
Best Regards,
Yan Zi
next prev parent reply other threads:[~2019-03-21 5:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 4:13 [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page() Anshuman Khandual
2019-03-21 5:01 ` Zi Yan [this message]
2019-03-21 5:33 ` Anshuman Khandual
2019-03-21 8:07 ` Michal Hocko
2019-03-21 8:13 ` Anshuman Khandual
2019-03-21 9:42 ` Oscar Salvador
2019-03-21 10:03 ` Michal Hocko
2019-03-22 9:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8AB57711-48C0-4D95-BC5F-26B266DC3AE8@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).