From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61323C47092 for ; Wed, 2 Jun 2021 15:18:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 008756138C for ; Wed, 2 Jun 2021 15:18:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 008756138C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 970366B0087; Wed, 2 Jun 2021 11:18:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 920A56B0088; Wed, 2 Jun 2021 11:18:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D6306B0089; Wed, 2 Jun 2021 11:18:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 3B3566B0087 for ; Wed, 2 Jun 2021 11:18:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CD6F0180AD804 for ; Wed, 2 Jun 2021 15:18:30 +0000 (UTC) X-FDA: 78209140380.10.B8425A4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id E94144202A33 for ; Wed, 2 Jun 2021 15:18:17 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7569622D64; Wed, 2 Jun 2021 15:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622647109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZtBS4fx+lTzBrHRbz8ggAcz3XolLf1vUw2zGmkr8u4=; b=sr+QcvkL7fYlG7CsDsFiexBEfTyt58eZZPoYyxa/KxtdymxUt5mTC0JfOOj9Bi9fuNV79M NXxG01DtNpRSlHeNQCCOe9CGJ2+Luj7uEASQE1aHq3MpR9s110Wm8jnJOQ23vFKxVGRWJQ 63tg7reRrxuQRRBwzYvdeavgAzBuuuc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622647109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZtBS4fx+lTzBrHRbz8ggAcz3XolLf1vUw2zGmkr8u4=; b=Jy1tGAiQeVFHsduDxPbljquxyI04oB0hKYEzdLxevuOBDewWHxUG2Q7GAlO1Q77Kkf8wXY v98MfTw+MznMC5Dw== Received: by imap.suse.de (Postfix, from userid 51) id 6C68B11CD5; Wed, 2 Jun 2021 16:20:03 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id D7E5911DA4; Wed, 2 Jun 2021 10:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622630930; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZtBS4fx+lTzBrHRbz8ggAcz3XolLf1vUw2zGmkr8u4=; b=YObkJak2xEKgggs+C041WX2XGHcsEw72USiZY+mFg/7g+68mL8bBON5F0wbC3spLTZ8iWU 8NZtYfd1a3P8nyemKGYKfQK7M5xPVrpsFYOKJGhOjKMRRy0XHzfkiD+LS7byM2TWkxUGVn /f39pWCsFHjOi5pfhUcuwaChVb8QS9Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622630930; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZtBS4fx+lTzBrHRbz8ggAcz3XolLf1vUw2zGmkr8u4=; b=3MSvg6W5KeWcdEP/VUkas4Qh/63MDJ/FsCIKQ/rz7Ms4uuOz5qNwmWKCLtH/ICp1Z2/OzS NcXNujrNccoXwSAg== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id lKMtNBFit2C0WgAALh3uQQ (envelope-from ); Wed, 02 Jun 2021 10:48:49 +0000 Subject: Re: [PATCH v3 4/4] slub: Force on no_hash_pointers when slub_debug is enabled To: Stephen Boyd , Andrew Morton , kernel test robot Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Petr Mladek , Joe Perches References: <20210601182202.3011020-5-swboyd@chromium.org> <202106020644.UDFIJOUU-lkp@intel.com> <20210601172659.fd8c40a6548a1bd43be1bf11@linux-foundation.org> From: Vlastimil Babka Message-ID: <8a464fef-0530-aebf-5844-c8aaf2bf6f37@suse.cz> Date: Wed, 2 Jun 2021 12:48:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sr+QcvkL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Jy1tGAiQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YObkJak2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3MSvg6W5; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E94144202A33 X-Stat-Signature: qec1aabi7edp1o1i6gqqoetiusc7aw7c X-HE-Tag: 1622647097-48070 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/2/21 3:03 AM, Stephen Boyd wrote: > Quoting Andrew Morton (2021-06-01 17:26:59) >> On Wed, 2 Jun 2021 06:45:55 +0800 kernel test robot wrote: >> >> > >> mm/slub.c:4464:30: error: use of undeclared identifier 'slub_debug_enabled' >> > if (static_branch_unlikely(&slub_debug_enabled)) >> > ^ >> > >> mm/slub.c:4464:30: error: use of undeclared identifier 'slub_debug_enabled' >> > >> mm/slub.c:4464:30: error: use of undeclared identifier 'slub_debug_enabled' >> > >> mm/slub.c:4464:30: error: use of undeclared identifier 'slub_debug_enabled' >> > >> mm/slub.c:4464:6: error: invalid argument type 'void' to unary expression >> > if (static_branch_unlikely(&slub_debug_enabled)) >> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> Thanks. Stephen, how about this? > > Looks good to me. Thanks for the quick fix! > >> >> --- a/mm/slub.c~slub-force-on-no_hash_pointers-when-slub_debug-is-enabled-fix >> +++ a/mm/slub.c >> @@ -117,12 +117,26 @@ >> */ >> >> #ifdef CONFIG_SLUB_DEBUG >> + >> #ifdef CONFIG_SLUB_DEBUG_ON >> DEFINE_STATIC_KEY_TRUE(slub_debug_enabled); >> #else >> DEFINE_STATIC_KEY_FALSE(slub_debug_enabled); >> #endif >> -#endif >> + >> +static inline bool __slub_debug_enabled(void) >> +{ >> + return static_branch_unlikely(&slub_debug_enabled); > > To make this even better it could be > > return static_branch_maybe(CONFIG_SLUB_DEBUG_ON, &slub_debug_enabled); > >> +} >> + >> +#else /* CONFIG_SLUB_DEBUG */ >> + >> +static inline bool __slub_debug_enabled(void) >> +{ >> + return false; >> +} >> + >> +#endif /* CONFIG_SLUB_DEBUG */ >> >> static inline bool kmem_cache_debug(struct kmem_cache *s) >> { >> @@ -4493,7 +4507,7 @@ void __init kmem_cache_init(void) >> slub_max_order = 0; >> >> /* Print slub debugging pointers without hashing */ >> - if (static_branch_unlikely(&slub_debug_enabled)) >> + if (__slub_debug_enabled()) A minimal fix would be to put this under #ifdef CONFIG_SLUB_DEBUG and use static_key_enabled() as we don't need the jump label optimization for init code. But the current fix works. > > It would be super cool if static branches could be optimized out when > they're never changed by any code, nor exported to code, just tested in > conditions. I've no idea if that is the case though. > >> no_hash_pointers_enable(NULL); >> >> kmem_cache_node = &boot_kmem_cache_node; >