linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	<mm-commits@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>
Subject: Re: + mm-gup-track-foll_pin-pages-fix-2.patch added to -mm tree
Date: Wed, 11 Mar 2020 17:14:40 -0700	[thread overview]
Message-ID: <8ab0ad90-4e6b-cbc1-e3e1-c62427486711@nvidia.com> (raw)
In-Reply-To: <20200311111352.1dff2984@p-imbrenda>

On 3/11/20 3:13 AM, Claudio Imbrenda wrote:
> On Tue, 10 Mar 2020 18:46:40 -0700
> John Hubbard <jhubbard@nvidia.com> wrote:
> 
>> On 3/7/20 3:25 PM, Andrew Morton wrote:
>>>
>>> The patch titled
>>>       Subject: mm/gup: fixup for 9947ea2c1e608e32 "mm/gup: track
>>> FOLL_PIN pages" has been added to the -mm tree.  Its filename is
>>>       mm-gup-track-foll_pin-pages-fix-2.patch
>>>    
>>
>> This appears to be causing a build failure in mm/gup.c, in mmotm, as
>> of today anyway:
>>
>>      commit 5d9ee416b570 ("pci: test for unexpectedly disabled
>> bridges")
>>
>>
>> I vaguely recall reviewing an earlier version that moved
>> put_compound_head() up higher in gup.c, in order to avoid this. In
> 
> yes, that is what I had sent
> 
>> any case, that's what this needs in order to build. Sorry for missing
>> it in the review.
> 
> I don't think you missed it, because the patch I sent out to be
> squashed did move it up
> 
>> Claudio, did you compile-test the patch? I'm not sure how this made
> 
> not only compile tested, I even actually tested-tested it.


Andrew, do you want Claudio to resend that patch? It seems like part of it
got lost, somehow.


thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2020-03-12  0:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200307232517.0eSNFUWfN%akpm@linux-foundation.org>
2020-03-11  1:46 ` + mm-gup-track-foll_pin-pages-fix-2.patch added to -mm tree John Hubbard
2020-03-11 10:13   ` Claudio Imbrenda
2020-03-12  0:14     ` John Hubbard [this message]
2020-03-12  0:51     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ab0ad90-4e6b-cbc1-e3e1-c62427486711@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=imbrenda@linux.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).