From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7016CC1975A for ; Wed, 18 Mar 2020 01:50:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BC6B206EC for ; Wed, 18 Mar 2020 01:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Jw2I7EDp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BC6B206EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB2DB6B0003; Tue, 17 Mar 2020 21:50:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C625A6B0006; Tue, 17 Mar 2020 21:50:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77F86B0007; Tue, 17 Mar 2020 21:50:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id A017F6B0003 for ; Tue, 17 Mar 2020 21:50:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 994DA82CD8C7 for ; Wed, 18 Mar 2020 01:50:08 +0000 (UTC) X-FDA: 76606802496.14.mind35_1dc974c1a714b X-HE-Tag: mind35_1dc974c1a714b X-Filterd-Recvd-Size: 2059 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Mar 2020 01:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=4mYn/J6WjuNc+sE6s7RyDvVdka/2uT/48Vop96I8Yvo=; b=Jw2I7EDp2y/yaAtud1bcHNSopW nK59w0GN4V/N98gXZtSduD4FMkHb9fIYpAY4a5iQbbARqUdHLj82p6nkKw4pS9hAIQP2LfWknCZLW hqZXRL4N8VD1vPht7GbICGwoPyAnZ864zqNiduOFXS8d57+sPfQBslfcCOVp+7pHcFCLTqD/zmRiA RrTHNKG1foZ/CzijE7v1CxfPqy0+LHSj/n/dH3fIFdaLWLznJU9sTBzVNKXa5iv1NtqV3nNxvGwF7 AlXZmcXDyRXhvczmoYD8rOSq1uoUonJl35ol66b2ZMs3cDxi0QivLKNAP9YtuIGma84YL9Mrc+cCw vyPZp6Ew==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jENqG-00024i-05; Wed, 18 Mar 2020 01:49:56 +0000 Subject: Re: [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random() To: George Spelvin , Kees Cook Cc: Dan Williams , linux-mm@kvack.org, Andrew Morton References: <20200317135035.GA19442@SDF.ORG> <202003171435.41F7F0DF9@keescook> <20200317230612.GB19442@SDF.ORG> <202003171619.23210A7E0@keescook> <20200318014410.GA2281@SDF.ORG> From: Randy Dunlap Message-ID: <8c75acae-f000-e4fe-48af-88d4becf2a67@infradead.org> Date: Tue, 17 Mar 2020 18:49:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200318014410.GA2281@SDF.ORG> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 3/17/20 6:44 PM, George Spelvin wrote: > + unsigned long r = READ_ONCE(rand), rshift = r << 1;; don't need the double ending ;; -- ~Randy