From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A551BC3F2D1 for ; Mon, 2 Mar 2020 06:06:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 388C32468E for ; Mon, 2 Mar 2020 06:06:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 388C32468E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=au1.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8306B6B0005; Mon, 2 Mar 2020 01:06:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E0466B0006; Mon, 2 Mar 2020 01:06:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CEB36B0007; Mon, 2 Mar 2020 01:06:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 558576B0005 for ; Mon, 2 Mar 2020 01:06:14 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0639F8245571 for ; Mon, 2 Mar 2020 06:06:14 +0000 (UTC) X-FDA: 76549387068.28.cow92_193de366c1735 X-HE-Tag: cow92_193de366c1735 X-Filterd-Recvd-Size: 11179 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 06:06:13 +0000 (UTC) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02265DCs124266 for ; Mon, 2 Mar 2020 01:06:12 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yfm50vh73-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 02 Mar 2020 01:06:12 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Mar 2020 06:06:09 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 2 Mar 2020 06:06:02 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 022661DR42926082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 2 Mar 2020 06:06:01 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F7E5AE057; Mon, 2 Mar 2020 06:06:01 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9BF9EAE04D; Mon, 2 Mar 2020 06:06:00 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 2 Mar 2020 06:06:00 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id CABC3A00BE; Mon, 2 Mar 2020 17:05:55 +1100 (AEDT) Subject: Re: [PATCH v3 16/27] powerpc/powernv/pmem: Register a character device for userspace to interact with From: "Alastair D'Silva" To: Andrew Donnellan Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Date: Mon, 02 Mar 2020 17:05:59 +1100 In-Reply-To: <1e980dc7-109a-d96f-1329-1c38918e2bba@linux.ibm.com> References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-17-alastair@au1.ibm.com> <1e980dc7-109a-d96f-1329-1c38918e2bba@linux.ibm.com> Organization: IBM Australia Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20030206-0016-0000-0000-000002EC1123 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20030206-0017-0000-0000-0000334F5136 Message-Id: <8cff2a36a2d9f50725c7df1292c4c6df79a1711d.camel@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-02_01:2020-02-28,2020-03-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxscore=0 clxscore=1015 bulkscore=0 spamscore=0 mlxlogscore=999 suspectscore=2 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003020046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2020-03-02 at 16:34 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > This patch introduces a character device (/dev/ocxl-scmX) which > > further > > patches will use to interact with userspace. > > As with the comments on other patches in this series, this commit > message is lacking in explanation. What's the purpose of this device? > I'll reword this for v4. > > Signed-off-by: Alastair D'Silva > > --- > > arch/powerpc/platforms/powernv/pmem/ocxl.c | 116 > > +++++++++++++++++- > > .../platforms/powernv/pmem/ocxl_internal.h | 2 + > > 2 files changed, 116 insertions(+), 2 deletions(-) > > > > diff --git a/arch/powerpc/platforms/powernv/pmem/ocxl.c > > b/arch/powerpc/platforms/powernv/pmem/ocxl.c > > index b8bd7e703b19..63109a870d2c 100644 > > --- a/arch/powerpc/platforms/powernv/pmem/ocxl.c > > +++ b/arch/powerpc/platforms/powernv/pmem/ocxl.c > > @@ -10,6 +10,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include "ocxl_internal.h" > > @@ -339,6 +340,9 @@ static void free_ocxlpmem(struct ocxlpmem > > *ocxlpmem) > > > > free_minor(ocxlpmem); > > > > + if (ocxlpmem->cdev.owner) > > + cdev_del(&ocxlpmem->cdev); > > + > > if (ocxlpmem->metadata_addr) > > devm_memunmap(&ocxlpmem->dev, ocxlpmem->metadata_addr); > > > > @@ -396,6 +400,70 @@ static int ocxlpmem_register(struct ocxlpmem > > *ocxlpmem) > > return device_register(&ocxlpmem->dev); > > } > > > > +static void ocxlpmem_put(struct ocxlpmem *ocxlpmem) > > +{ > > + put_device(&ocxlpmem->dev); > > +} > > + > > +static struct ocxlpmem *ocxlpmem_get(struct ocxlpmem *ocxlpmem) > > +{ > > + return (get_device(&ocxlpmem->dev) == NULL) ? NULL : ocxlpmem; > > +} > > + > > +static struct ocxlpmem *find_and_get_ocxlpmem(dev_t devno) > > +{ > > + struct ocxlpmem *ocxlpmem; > > + int minor = MINOR(devno); > > + /* > > + * We don't declare an RCU critical section here, as our AFU > > + * is protected by a re0ference counter on the device. By the > > time the > > + * minor number of a device is removed from the idr, the ref > > count of > > + * the device is already at 0, so no user API will access that > > AFU and > > + * this function can't return it. > > + */ > > + ocxlpmem = idr_find(&minors_idr, minor); > > + if (ocxlpmem) > > + ocxlpmem_get(ocxlpmem); > > + return ocxlpmem; > > +} > > + > > +static int file_open(struct inode *inode, struct file *file) > > +{ > > + struct ocxlpmem *ocxlpmem; > > + > > + ocxlpmem = find_and_get_ocxlpmem(inode->i_rdev); > > + if (!ocxlpmem) > > + return -ENODEV; > > + > > + file->private_data = ocxlpmem; > > + return 0; > > +} > > + > > +static int file_release(struct inode *inode, struct file *file) > > +{ > > + struct ocxlpmem *ocxlpmem = file->private_data; > > + > > + ocxlpmem_put(ocxlpmem); > > + return 0; > > +} > > + > > +static const struct file_operations fops = { > > + .owner = THIS_MODULE, > > + .open = file_open, > > + .release = file_release, > > +}; > > + > > +/** > > + * create_cdev() - Create the chardev in /dev for the device > > + * @ocxlpmem: the SCM metadata > > + * Return: 0 on success, negative on failure > > + */ > > +static int create_cdev(struct ocxlpmem *ocxlpmem) > > +{ > > + cdev_init(&ocxlpmem->cdev, &fops); > > + return cdev_add(&ocxlpmem->cdev, ocxlpmem->dev.devt, 1); > > +} > > + > > /** > > * ocxlpmem_remove() - Free an OpenCAPI persistent memory device > > * @pdev: the PCI device information struct > > @@ -572,6 +640,11 @@ static int probe(struct pci_dev *pdev, const > > struct pci_device_id *ent) > > goto err; > > } > > > > + if (create_cdev(ocxlpmem)) { > > + dev_err(&pdev->dev, "Could not create character > > device\n"); > > + goto err; > > + } > > + > > elapsed = 0; > > timeout = ocxlpmem->readiness_timeout + ocxlpmem- > > >memory_available_timeout; > > while (!is_usable(ocxlpmem, false)) { > > @@ -613,20 +686,59 @@ static struct pci_driver pci_driver = { > > .shutdown = ocxlpmem_remove, > > }; > > > > +static int file_init(void) > > +{ > > + int rc; > > + > > + mutex_init(&minors_idr_lock); > > + idr_init(&minors_idr); > > + > > + rc = alloc_chrdev_region(&ocxlpmem_dev, 0, NUM_MINORS, "ocxl- > > pmem"); > > If the driver is going to be called "ocxlpmem" can we standardise on > that without the extra hyphen? Ok > > + if (rc) { > > + idr_destroy(&minors_idr); > > + pr_err("Unable to allocate OpenCAPI persistent memory > > major number: %d\n", rc); > > + return rc; > > + } > > + > > + ocxlpmem_class = class_create(THIS_MODULE, "ocxl-pmem"); > > + if (IS_ERR(ocxlpmem_class)) { > > + idr_destroy(&minors_idr); > > + pr_err("Unable to create ocxl-pmem class\n"); > > + unregister_chrdev_region(ocxlpmem_dev, NUM_MINORS); > > + return PTR_ERR(ocxlpmem_class); > > + } > > + > > + return 0; > > +} > > + > > +static void file_exit(void) > > +{ > > + class_destroy(ocxlpmem_class); > > + unregister_chrdev_region(ocxlpmem_dev, NUM_MINORS); > > + idr_destroy(&minors_idr); > > +} > > + > > static int __init ocxlpmem_init(void) > > { > > - int rc = 0; > > + int rc; > > > > - rc = pci_register_driver(&pci_driver); > > + rc = file_init(); > > if (rc) > > return rc; > > > > + rc = pci_register_driver(&pci_driver); > > + if (rc) { > > + file_exit(); > > + return rc; > > + } > > + > > return 0; > > } > > > > static void ocxlpmem_exit(void) > > { > > pci_unregister_driver(&pci_driver); > > + file_exit(); > > } > > > > module_init(ocxlpmem_init); -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819