From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D53C5C4338F for ; Tue, 10 Aug 2021 16:04:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6ED35610A7 for ; Tue, 10 Aug 2021 16:04:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6ED35610A7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BE4D48D0005; Tue, 10 Aug 2021 12:04:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B94878D0001; Tue, 10 Aug 2021 12:04:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83F78D0005; Tue, 10 Aug 2021 12:04:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 8CDD18D0001 for ; Tue, 10 Aug 2021 12:04:36 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 36A5422867 for ; Tue, 10 Aug 2021 16:04:36 +0000 (UTC) X-FDA: 78459643752.40.F425554 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id 75365B004DE2 for ; Tue, 10 Aug 2021 16:04:35 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6FC862206A; Tue, 10 Aug 2021 16:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628611474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9hOZdmGXF7uPz0UrOXyZ72hX+fcy1HDX0c3Fsbxfqo=; b=F8Ybk1/d5s7NGQ2OACApxGGPjSYj8MIhrKA3Ho8AEIHDYlFeOayuX9OURfIRPdpyQQZYmR ZqJ5nam597n1+rahglZ9Jy5yGt9v+pGv1TC6VR2B5mwqzYXhAAeRUiN3doGBnoR04OC5MS OBRX0s5Y70i5pVIOxfs9yV7PVgOluxM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628611474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9hOZdmGXF7uPz0UrOXyZ72hX+fcy1HDX0c3Fsbxfqo=; b=QwypvChq2ShHegLeWuyOUNAHOEL0UWnX9W33H3l8B4h4bSF19JOB5t1tYZ+VtZUzVWhuuD 8FXCiFus+PFDH2Dg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 4EAE5137DA; Tue, 10 Aug 2021 16:04:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id J+eSEpKjEmEeTAAAGKfGzw (envelope-from ); Tue, 10 Aug 2021 16:04:34 +0000 Subject: Re: [PATCH v14 017/138] mm/filemap: Add folio_unlock() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , William Kucharski , David Howells References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-18-willy@infradead.org> From: Vlastimil Babka Message-ID: <8e1fe292-937d-87d2-1c36-8ff5c30bfefe@suse.cz> Date: Tue, 10 Aug 2021 18:04:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-18-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="F8Ybk1/d"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QwypvChq; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: j5tj4g97awhumoudwtmic6i8qoyhox3q X-Rspamd-Queue-Id: 75365B004DE2 X-Rspamd-Server: rspam01 X-HE-Tag: 1628611475-647301 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > Convert unlock_page() to call folio_unlock(). By using a folio we > avoid a call to compound_head(). This shortens the function from 39 > bytes to 25 and removes 4 instructions on x86-64. Because we still > have unlock_page(), it's a net increase of 16 bytes of text for the > kernel as a whole, but any path that uses folio_unlock() will execute > 4 fewer instructions. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Reviewed-by: William Kucharski > Reviewed-by: David Howells Acked-by: Vlastimil Babka