From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v1 5/6] mm/page_alloc: restrict ZONE_MOVABLE optimization in has_unmovable_pages() to memory offlining
Date: Mon, 27 Jul 2020 14:23:50 +0200 [thread overview]
Message-ID: <8f0dfc91-bf91-4d9c-a4f5-ebaeb568b39b@redhat.com> (raw)
In-Reply-To: <20200630142639.22770-6-david@redhat.com>
On 30.06.20 16:26, David Hildenbrand wrote:
> We can already have pages that can be offlined but not allocated in
> ZONE_MOVABLE - PageHWPoison pages. While these pages can be skipped when
> offlining ("moving them to /dev/null"), we cannot move them when
> allocating.
>
> virtio-mem managed memory is similar. The logical memory holes
> corresponding to unplug memory ranges can be skipped when offlining,
> however, the pages cannot be moved. Currently, virtio-mem special-cases
> ZONE_MOVABLE, such that:
> - partially plugged memory blocks it added to Linux cannot be onlined to
> ZONE_MOVABLE
> - when unplugging memory, it will never consider memory blocks that were
> onlined to ZONE_MOVABLE
>
> We also want to support ZONE_MOVABLE in virtio-mem for both cases. Note
> that virtio-mem does not blindly try to unplug random pages within its
> managed memory region. It always plugs memory left-to-right and tries to
> unplug memory right-to-left - in roughly MAX_ORDER - 1 granularity. In
> theory, the movable ZONE part would only shrink when unplugging memory
> from ZONE_MOVABLE.
>
> Let's perform the ZONE_MOVABLE optimization only for memory offlining,
> such that we reduce the number of false positives from
> has_unmovable_pages() in case of alloc_contig_range() on ZONE_MOVABLE.
>
> Note: We currently don't seem to have any user of alloc_contig_range()
> that actually uses ZONE_MOVABLE. This change is mostly valuable for the
> documentation.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> mm/page_alloc.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bd3ebf08f09b9..45077d74d975d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8237,9 +8237,12 @@ struct page *has_unmovable_pages(struct zone *zone, struct page *page,
> /*
> * If the zone is movable and we have ruled out all reserved
> * pages then it should be reasonably safe to assume the rest
> - * is movable.
> + * is movable. As we can have some pages in the movable zone
> + * that are only considered movable for memory offlining (esp.,
> + * PageHWPoison and PageOffline that will be skipped), we
> + * perform this optimization only for memory offlining.
> */
> - if (zone_idx(zone) == ZONE_MOVABLE)
> + if ((flags & MEMORY_OFFLINE) && zone_idx(zone) == ZONE_MOVABLE)
> continue;
>
> /*
>
So, as we don't have any alloc_contig_range() users that use
ZONE_MOVABLE for now, and virtio-mem will be the only one for now (which
accounts for 50% of the special cases - PG_offline), I think we might
drop this patch.
Worst think is that if we ever have other alloc_contig_range() users,
that we return "false" from has_unmovable_pages() and fail later when
trying to migrate/isolate all pages. This should, however, only happen
in rare cases (and there are already other cases where we have basically
unmovable data - long-term pinnings).
On the plus side, keeping the ZONE_MOVABLE optimizations here also
allows virtio-mem to better tolerate unstable page flags when trying to
alloc_contig_range().
Thoughts?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-07-27 12:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 14:26 [PATCH v1 0/6] mm / virtio-mem: support ZONE_MOVABLE David Hildenbrand
2020-06-30 14:26 ` [PATCH v1 1/6] mm/page_alloc: tweak comments in has_unmovable_pages() David Hildenbrand
2020-07-28 13:48 ` Baoquan He
2020-07-28 14:07 ` David Hildenbrand
2020-07-29 10:47 ` Baoquan He
2020-07-29 12:29 ` David Hildenbrand
2020-06-30 14:26 ` [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate() David Hildenbrand
2020-07-28 13:56 ` Baoquan He
2020-07-29 17:31 ` Mike Kravetz
2020-07-29 18:08 ` David Hildenbrand
2020-07-29 18:35 ` Mike Kravetz
2020-07-29 18:41 ` David Hildenbrand
2020-07-30 4:21 ` Pankaj Gupta
2020-06-30 14:26 ` [PATCH v1 3/6] mm/page_isolation: drop WARN_ON_ONCE() " David Hildenbrand
2020-07-29 13:24 ` Baoquan He
2020-07-29 13:37 ` David Hildenbrand
2020-07-29 14:05 ` Baoquan He
2020-06-30 14:26 ` [PATCH v1 4/6] mm/page_isolation: cleanup set_migratetype_isolate() David Hildenbrand
2020-07-29 14:06 ` Baoquan He
2020-07-30 4:31 ` Pankaj Gupta
2020-06-30 14:26 ` [PATCH v1 5/6] mm/page_alloc: restrict ZONE_MOVABLE optimization in has_unmovable_pages() to memory offlining David Hildenbrand
2020-07-27 12:23 ` David Hildenbrand [this message]
2020-06-30 14:26 ` [PATCH v1 6/6] virtio-mem: don't special-case ZONE_MOVABLE David Hildenbrand
2020-07-21 9:59 ` [PATCH v1 0/6] mm / virtio-mem: support ZONE_MOVABLE David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f0dfc91-bf91-4d9c-a4f5-ebaeb568b39b@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).