From: Michael Keyes <mgkeyes@vigovproductions.net>
To: Tad <support@spotco.us>, liam.howlett@oracle.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rick.p.edgecombe@intel.com
Subject: Re: [PATCH v2] mm/mmap: Regression fix for unmapped_area{_topdown}
Date: Sun, 30 Apr 2023 23:41:35 +0100 [thread overview]
Message-ID: <90777046-a420-b19f-1847-d353b9938131@vigovproductions.net> (raw)
In-Reply-To: <e6108286ac025c268964a7ead3aab9899f9bc6e9.camel@spotco.us>
On 29.04.23 15:32, Tad wrote:
> This reintroduces the issue described in
> https://lore.kernel.org/linux-mm/cb8dc31a-fef2-1d09-f133-e9f7b9f9e77a@sony.com/
Yes, I also ran into this (even though I'd somehow missed it the
previous time).
Apparently the issue arises at mm/mmap.c:1582, where low_limit is set to
vm_end_gap(tmp). Occasionally, this returns a 64-bit address (e.g.
0x7fedea581000), which is obviously greater than high_limit for a 32-bit
mmap, and causes the next call to mas_empty_area() to fail.
I'm not sure why vm_end_gap(tmp) occasionally returns a 64-bit address,
or if the best solution is to just check for this and skip the retry if
it occurs…
--
Michael
next prev parent reply other threads:[~2023-04-30 22:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 14:57 [PATCH 1/3] maple_tree: Make maple state reusable after mas_empty_area_rev() Liam R. Howlett
2023-04-14 14:57 ` [PATCH 2/3] maple_tree: Fix mas_empty_area() search Liam R. Howlett
2023-04-14 14:57 ` [PATCH 3/3] mm/mmap: Regression fix for unmapped_area{_topdown} Liam R. Howlett
2023-04-14 16:27 ` Edgecombe, Rick P
2023-04-14 17:26 ` Liam R. Howlett
2023-04-14 17:29 ` Liam R. Howlett
2023-04-14 17:53 ` Edgecombe, Rick P
2023-04-14 18:07 ` Liam R. Howlett
2023-04-14 18:21 ` Edgecombe, Rick P
2023-04-14 18:59 ` [PATCH v2] " Liam R. Howlett
2023-04-14 19:09 ` Andrew Morton
2023-04-29 14:32 ` Tad
2023-04-30 22:41 ` Michael Keyes [this message]
2023-05-02 14:08 ` Liam R. Howlett
2023-05-02 14:09 ` Liam R. Howlett
2023-05-15 8:57 ` Juhyung Park
2023-05-15 14:36 ` Liam R. Howlett
2023-04-19 9:02 ` [PATCH 1/3] maple_tree: Make maple state reusable after mas_empty_area_rev() Peng Zhang
2023-04-19 22:54 ` Liam R. Howlett
2023-04-20 4:21 ` Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90777046-a420-b19f-1847-d353b9938131@vigovproductions.net \
--to=mgkeyes@vigovproductions.net \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rick.p.edgecombe@intel.com \
--cc=support@spotco.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).