From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D093C2B9F8 for ; Tue, 25 May 2021 15:04:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D18B96140E for ; Tue, 25 May 2021 15:04:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D18B96140E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 01E446B0036; Tue, 25 May 2021 11:04:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0EBB6B006E; Tue, 25 May 2021 11:04:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0846B0070; Tue, 25 May 2021 11:04:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id AD19A6B0036 for ; Tue, 25 May 2021 11:04:50 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3DAC1180AD830 for ; Tue, 25 May 2021 15:04:50 +0000 (UTC) X-FDA: 78180075540.31.0BE4ADB Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf06.hostedemail.com (Postfix) with ESMTP id 6BC44C0042E5 for ; Tue, 25 May 2021 15:04:43 +0000 (UTC) IronPort-SDR: r4z1scI386YLcWvqM4GORv7hKwuM6IbpYD9zdCIj/8WQZgersgFXaAdSo2Axps1I0Kj3JNIq9m R5Cq/3r68NXA== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="266107177" X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="266107177" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 08:03:24 -0700 IronPort-SDR: nrw6C2L0FRFrHa4m4gp1TR5TsTcNGmIi7bIhjT1Elk2IgJhHWKWAfx53xW84jcfLUrhsHWxgSk ZICHsDfzQsXQ== X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="414061051" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.209.133.101]) ([10.209.133.101]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 08:03:21 -0700 Subject: Re: [PATCH v27 30/31] mm: Update arch_validate_flags() to test vma anonymous To: Catalin Marinas Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , "Kirill A . Shutemov" , Vincenzo Frascino , Will Deacon References: <20210521221211.29077-1-yu-cheng.yu@intel.com> <20210521221211.29077-31-yu-cheng.yu@intel.com> <20210525110011.GD15564@arm.com> From: "Yu, Yu-cheng" Message-ID: <908938ec-912b-9190-40e0-11ca88e8f0d7@intel.com> Date: Tue, 25 May 2021 08:03:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210525110011.GD15564@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf06.hostedemail.com: domain of yu-cheng.yu@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=yu-cheng.yu@intel.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6BC44C0042E5 X-Stat-Signature: u4pt9gmjrdfmk9sec669otfdroout99p X-HE-Tag: 1621955083-159644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/2021 4:00 AM, Catalin Marinas wrote: > On Fri, May 21, 2021 at 03:12:10PM -0700, Yu-cheng Yu wrote: >> When newer VM flags are being created, such as VM_MTE, it becomes necessary >> for mmap/mprotect to verify if certain flags are being applied to an >> anonymous VMA. >> >> To solve this, one approach is adding a VM flag to track that MAP_ANONYMOUS >> is specified [1], and then using the flag in arch_validate_flags(). >> >> Another approach is passing the VMA to arch_validate_flags(), and check >> vma_is_anonymous(). >> >> To prepare the introduction of PROT_SHADOW_STACK, which creates a shadow >> stack mapping and can be applied only to an anonymous VMA, update >> arch_validate_flags() to pass in the VMA. >> >> [1] commit 9f3419315f3c ("arm64: mte: Add PROT_MTE support to mmap() and mprotect()"), >> >> Signed-off-by: Yu-cheng Yu >> Reviewed-by: Kirill A. Shutemov >> Cc: Catalin Marinas >> Cc: Kees Cook >> Cc: Vincenzo Frascino >> Cc: Will Deacon > > For arm64: > > Acked-by: Catalin Marinas > Thanks!