From: TSUKADA Koutaro <tsukada@ascade.co.jp>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>,
David Rientjes <rientjes@google.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Marc-Andre Lureau <marcandre.lureau@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v2 0/7] mm: pages for hugetlb's overcommit may be able to charge to memcg
Date: Tue, 22 May 2018 21:56:42 +0900 [thread overview]
Message-ID: <9456064b-3ae1-0234-a1fc-918708156b6a@ascade.co.jp> (raw)
In-Reply-To: <871se5ysbg.fsf@e105922-lin.cambridge.arm.com>
Hi Punit,
On 2018/05/21 23:52, Punit Agrawal wrote:
> Hi Tsukada,
>
> I was staring at memcg code to better understand your changes and had
> the below thought.
>
> TSUKADA Koutaro <tsukada@ascade.co.jp> writes:
>
> [...]
>
>> In this patch-set, introduce the charge_surplus_huge_pages(boolean) to
>> struct hstate. If it is true, it charges to the memory cgroup to which the
>> task that obtained surplus hugepages belongs. If it is false, do nothing as
>> before, and the default value is false. The charge_surplus_huge_pages can
>> be controlled procfs or sysfs interfaces.
>
> Instead of tying the surplus huge page charging control per-hstate,
> could the control be made per-memcg?
>
> This can be done by introducing a per-memory controller file in sysfs
> (memory.charge_surplus_hugepages?) that indicates whether surplus
> hugepages are to be charged to the controller and forms part of the
> total limit. IIUC, the limit already accounts for page and swap cache
> pages.
>
> This would allow the control to be enabled per-cgroup and also keep the
> userspace control interface in one place.
>
> As said earlier, I'm not familiar with memcg so the above might not be a
> feasible but think it'll lead to a more coherent user
> interface. Hopefully, more knowledgeable folks on the thread can chime
> in.
>
Thank you for good advise.
As you mentioned, it is better to be able to control by per-memcg. After
organizing my thoughts, I will develop the next version patch-set that can
solve issues and challenge again.
Thanks,
Tsukada
> Thanks,
> Punit
>
>> Since THP is very effective in environments with kernel page size of 4KB,
>> such as x86, there is no reason to positively use HugeTLBfs, so I think
>> that there is no situation to enable charge_surplus_huge_pages. However, in
>> some distributions such as arm64, the page size of the kernel is 64KB, and
>> the size of THP is too huge as 512MB, making it difficult to use. HugeTLBfs
>> may support multiple huge page sizes, and in such a special environment
>> there is a desire to use HugeTLBfs.
>>
>> The patch set is for 4.17.0-rc3+. I don't know whether patch-set are
>> acceptable or not, so I just done a simple test.
>>
>> Thanks,
>> Tsukada
>>
>> TSUKADA Koutaro (7):
>> hugetlb: introduce charge_surplus_huge_pages to struct hstate
>> hugetlb: supports migrate charging for surplus hugepages
>> memcg: use compound_order rather than hpage_nr_pages
>> mm, sysctl: make charging surplus hugepages controllable
>> hugetlb: add charge_surplus_hugepages attribute
>> Documentation, hugetlb: describe about charge_surplus_hugepages
>> memcg: supports movement of surplus hugepages statistics
>>
>> Documentation/vm/hugetlbpage.txt | 6 +
>> include/linux/hugetlb.h | 4 +
>> kernel/sysctl.c | 7 +
>> mm/hugetlb.c | 148 +++++++++++++++++++++++++++++++++++++++
>> mm/memcontrol.c | 109 +++++++++++++++++++++++++++-
>> 5 files changed, 269 insertions(+), 5 deletions(-)
next prev parent reply other threads:[~2018-05-22 12:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 4:27 [PATCH v2 0/7] mm: pages for hugetlb's overcommit may be able to charge to memcg TSUKADA Koutaro
2018-05-18 4:29 ` [PATCH v2 1/7] hugetlb: introduce charge_surplus_huge_pages to struct hstate TSUKADA Koutaro
2018-05-18 4:32 ` [PATCH v2 2/7] hugetlb: support migrate charging for surplus hugepages TSUKADA Koutaro
2018-05-18 4:34 ` [PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages TSUKADA Koutaro
2018-05-18 17:46 ` Punit Agrawal
2018-05-18 17:51 ` Punit Agrawal
2018-05-21 3:48 ` TSUKADA Koutaro
2018-05-21 14:53 ` Punit Agrawal
2018-05-18 4:36 ` [PATCH v2 4/7] mm, sysctl: make charging surplus hugepages controllable TSUKADA Koutaro
2018-05-18 4:37 ` [PATCH v2 5/7] hugetlb: add charge_surplus_hugepages attribute TSUKADA Koutaro
2018-05-18 4:39 ` [PATCH v2 6/7] Documentation, hugetlb: describe about charge_surplus_hugepages, TSUKADA Koutaro
2018-05-18 4:41 ` [PATCH v2 7/7] memcg: supports movement of surplus hugepages statistics TSUKADA Koutaro
2018-05-21 14:52 ` [PATCH v2 0/7] mm: pages for hugetlb's overcommit may be able to charge to memcg Punit Agrawal
2018-05-22 12:56 ` TSUKADA Koutaro [this message]
2018-05-21 18:07 ` Mike Kravetz
2018-05-22 13:04 ` TSUKADA Koutaro
2018-05-22 18:54 ` Michal Hocko
2018-05-24 4:39 ` TSUKADA Koutaro
2018-05-24 8:20 ` Michal Hocko
2018-05-24 12:58 ` TSUKADA Koutaro
2018-05-24 13:24 ` Michal Hocko
2018-05-25 1:51 ` TSUKADA Koutaro
2018-05-22 20:28 ` Mike Kravetz
2018-05-22 13:51 ` Michal Hocko
2018-05-24 4:26 ` TSUKADA Koutaro
2018-05-24 8:27 ` Michal Hocko
2018-05-24 17:45 ` Mike Kravetz
2018-05-25 1:55 ` TSUKADA Koutaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9456064b-3ae1-0234-a1fc-918708156b6a@ascade.co.jp \
--to=tsukada@ascade.co.jp \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcandre.lureau@redhat.com \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=punit.agrawal@arm.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).