From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1991C6FD1D for ; Mon, 20 Mar 2023 11:00:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09B976B0074; Mon, 20 Mar 2023 07:00:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04C516B0075; Mon, 20 Mar 2023 07:00:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2E1F6B0078; Mon, 20 Mar 2023 07:00:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D564B6B0074 for ; Mon, 20 Mar 2023 07:00:12 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9ACE6AAC86 for ; Mon, 20 Mar 2023 11:00:12 +0000 (UTC) X-FDA: 80588982264.14.2AF2126 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 09269100021 for ; Mon, 20 Mar 2023 11:00:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IJUYqa4F; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679310010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YvwS21V87OZURkjfZ9iHLFx7wse477fWO8o7cVdC8zE=; b=tPeVIMrndQt1NXnZjDxqSoF2DNbf/hGtM3gO7x6BaSeARtruvO6xj9LyvzBzYFLcGKZ/CO Ylpt2DroeH0Litld9Gk5u5kkM4t2cgLHQVr8vNvB8qHx3nJzjCLwqPCAfzATwDzGUirClm ym/pV/4QvERdYqngkTUrsUkXM5gK/Ts= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IJUYqa4F; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679310010; a=rsa-sha256; cv=none; b=d7gXxu45A3S8DLsteFsF7sZBr6TNWHZoOs4uAUYgl54MhFLDxkn0oNrD5mN8h6qJe9t/lx kT6laQcLn3CIjiaQkKTNaYGMBs460R1M9xWMykZQHd3lmUdKCC4tu9NRVd8yC/62WqkIaz YIdlMor55wc9tRmdPFtfzqWqV+5Xye4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679310009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YvwS21V87OZURkjfZ9iHLFx7wse477fWO8o7cVdC8zE=; b=IJUYqa4FPX6394S4Jiz2Bu0NFWnQm9b1dDk37HZNf64UKC0Vy0KyKsn7JRkYrxWt2dTeLP uXZlt5XV4J7eKyOgyU2k8x9J39FYjhbXzFIcpR+vSjSGXs4mUu23exnoe/8mgcxuQcbJuM hyvtrgceIWarlC3RTARVA4xKsKit880= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-4bvZptJfNau7hlabMYz4FQ-1; Mon, 20 Mar 2023 07:00:06 -0400 X-MC-Unique: 4bvZptJfNau7hlabMYz4FQ-1 Received: by mail-wr1-f69.google.com with SMTP id bn9-20020a056000060900b002cfe8493fe6so1362386wrb.4 for ; Mon, 20 Mar 2023 04:00:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679310005; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YvwS21V87OZURkjfZ9iHLFx7wse477fWO8o7cVdC8zE=; b=vXaGnjyoiv22VCQUDHy0h6ubswuidVVB72d+CX2AZv8TF5eS2ScylJpevVjL9i6iJu 4rM5j/Idj2W0RAFUowKyGoUox9yZ/2MQ/1o9A8QStQGmtooDph7owdF3YPrylYH/FsrX fxNSbQG78E1cPtuur6PWxC4naHoXXMx+5ifOMTbDsfoomkJkePyaFNb6nd7pdMG0ODQE e+h9jmHMFC4bHmP5OORP+XU31flvnEd3LDoHMy6gZ2Jek8lw8SoIl/jlb1eGV29S4ZUH 2hvm3PBWWaYIR8SZBqjLpvoEjpymrYdQYDd162UcGxfjXEe2WiMRIyASrMvuN1R3GCf6 KsSQ== X-Gm-Message-State: AO0yUKWN741yTikjrlioAWiu9QriSkzbmP6TeAxCOipMngqQdH6qmfa7 paarNWx5ggcYLpcJIr4qH9z9JhNwcSwuqLCDW/LZh+sy+6OcpswNy1FtVmGu9DthOLaXE0xbwYC BNdbVBTBl+2Q= X-Received: by 2002:adf:fb01:0:b0:2ce:b7a1:c1a3 with SMTP id c1-20020adffb01000000b002ceb7a1c1a3mr13234743wrr.3.1679310005014; Mon, 20 Mar 2023 04:00:05 -0700 (PDT) X-Google-Smtp-Source: AK7set+Nm/AP50JtymPg9eFJ2hX8KoBE8+/Y4A7ha4GmGX4nlc3yTngMWY2fH+jF7oTeCP5yHiDIEA== X-Received: by 2002:adf:fb01:0:b0:2ce:b7a1:c1a3 with SMTP id c1-20020adffb01000000b002ceb7a1c1a3mr13234726wrr.3.1679310004672; Mon, 20 Mar 2023 04:00:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id u8-20020adfdb88000000b002cff06039d7sm8616030wri.39.2023.03.20.04.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 04:00:04 -0700 (PDT) Message-ID: <94d228b4-3d49-8cb0-a45c-3342c8b1da22@redhat.com> Date: Mon, 20 Mar 2023 12:00:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v8 26/40] mm: Warn on shadow stack memory in wrong vma To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, szabolcs.nagy@arm.com References: <20230319001535.23210-1-rick.p.edgecombe@intel.com> <20230319001535.23210-27-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230319001535.23210-27-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: jm458sbtumrexe8h3tbtbhnmtfdgehkn X-Rspam-User: X-Rspamd-Queue-Id: 09269100021 X-Rspamd-Server: rspam06 X-HE-Tag: 1679310009-361925 X-HE-Meta: U2FsdGVkX18MorL/pPICSr/nBU2/LGZ/ggMv7FNHSl74JTTfqDdI2gsHyBfxEIZlCGNZ2lXwIX10Rk/juOsJIBiSFpQAfG+3T0cANRB9CAbGCrnM9mnpnNfsgagkF3DKAURl/PsqlAG3BC7ifHCcXGgvwa/nARPkxpmgOmJaVKFojFKxJlENSO0n3WVC/aL4oM/nLmPO27w1GZybdyJPt95po/KghKaerVZ1Zw52ZrC+cIKL+tueSIr9HBsOMh/jeJvBdME4+aU8Fs1P5M8l6bzdr3Xkumbu1i5L2MTRQqf92aF3VOxr7vksgovXS0U6ZZzh8JBRWIAeZ096O/iRChybN2nbTP7K/+RLSnXJ5cH9/J8S51Vo4DWXhHK7pfRgXkfJU03mf3plKUJDkgyRp/WvtCGnJj5wKiH0tGZXd89VkEJoj/Xaa/mPlzKn8Uo5YIoWLSzLElfYPvKofA9nmOMMAoXs3bYHlbSE92QxPSURO3f+Hut+jvsJVP+4GnIUB0JBKfT2T+PNM0WrnZe/A19cWLDnm3y/Dv0ls65TmvRd6CVjOB9xe6Kpy5Je2H64RpNaQ/q1Q3Ya0T3xukBbqZJSKVVc5w6h9RhfUxDUH7ntw4bi0QVOWc8cKpfxzRl9xDhn3hLC8lChTyEmg1pMEsPRI+a9c4J4r6S8iW+VOUK6ZJcmSpg3RmBzyLqbgQVDVgCBmCMp5iS3G8IuLfBs4IwDCitvTDTBUzE+snJ+vQI8gWu6AHJfpz4KJvd6K/hvrtKZ3r5/1HK6mOcdoeazi4zCypoNOgfgKygmxSAQOnFrQVJn3Vy04V54UTcvz/9gFeJJ2BGvQgy9RzjHlyCmCTZeyySfJnNo2LMwRwM25/+zNfYM+GLLKP8w/9pH0Fgobqp2thfiDLAN8GgqAm0cOO6JDUEunJRMjBEtbtiIh5fKfNwSETnQcsw26Lb8ETN3BY95wOzA74xER+uShFf q93Nonn+ f/eFStoR2IeGrvSDHfWiBdFfz2I0lebylYVVxDsezLWZT7C0IJFeXbFJwXNDNl8HZ/vWyb8V20rECUMNqN/CwlpVkI0wTMPk17d3rtX54CfNfmujvTe7AyM0ND8X8ug5PLZRBRcBpetIt3K1kAq5vxoj4MO8eTa4Z2wZrL8KDkSjaIsGWnH4Zwu53k0Cf7LYEzxaSaa8OiG2+BbnKAGr25ZuaqNd2obtelBiqc8zY2TfWyNjjJ3iFk3SQ+2OLQHVZIUTw9xTsW9o5ZFbeB5iInJ0z14YuuRqppP77u10L2WTd2yK7RuAWmX5sP+9Vo90A+2Xj213Xca5nJwpgfn3W2FFC9z+hQyB67B7bKutmcrh3Ne4JykWOYDDsBdbyP+oxBtx4Rzr4Q3Ai//w/tlLcvnNJfczrO6ikh1rFlwE9/pTkhXYySvsWhl8limMDS1oOS+udCJm1wrJzueuWVDv6VLZwuHbNaeZmGI8q2p4h2vmKAg7PdUlKvhfrTW9u4DdPuC7Jzvu9DVftFrJqpJ/h3a+gssOu825hS8oAwlnQLYZyJiIcTZmhM6Lrbki9lmoegcKLSasL5Q48xH5jay2wD2J7G1tbSTa568wPGS54MpTqprtXQvWuTdZhPNhAwFyv1yltnVEDonrEFVBKZvdVMfV3Jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.03.23 01:15, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One sharp edge is that PTEs that are both Write=0 and Dirty=1 are > treated as shadow by the CPU, but this combination used to be created by > the kernel on x86. Previous patches have changed the kernel to now avoid > creating these PTEs unless they are for shadow stack memory. In case any > missed corners of the kernel are still creating PTEs like this for > non-shadow stack memory, and to catch any re-introductions of the logic, > warn if any shadow stack PTEs (Write=0, Dirty=1) are found in non-shadow > stack VMAs when they are being zapped. This won't catch transient cases > but should have decent coverage. It will be compiled out when shadow > stack is not configured. > > In order to check if a PTE is shadow stack in core mm code, add two arch > breakouts arch_check_zapped_pte/pmd(). This will allow shadow stack > specific code to be kept in arch/x86. > > Signed-off-by: Rick Edgecombe > Reviewed-by: Kees Cook > Acked-by: Mike Rapoport (IBM) > Tested-by: Pengfei Xu > Tested-by: John Allen > Tested-by: Kees Cook Acked-by: David Hildenbrand -- Thanks, David / dhildenb