From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A56C35250 for ; Mon, 10 Feb 2020 05:35:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B2E2214DB for ; Mon, 10 Feb 2020 05:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B2E2214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E2AB16B00B4; Mon, 10 Feb 2020 00:35:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDAFD6B00B5; Mon, 10 Feb 2020 00:35:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA41A6B00B6; Mon, 10 Feb 2020 00:35:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id B30DC6B00B4 for ; Mon, 10 Feb 2020 00:35:56 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5C3EE2DFD for ; Mon, 10 Feb 2020 05:35:56 +0000 (UTC) X-FDA: 76473105912.02.pipe92_8b0822a56e334 X-HE-Tag: pipe92_8b0822a56e334 X-Filterd-Recvd-Size: 7508 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Feb 2020 05:35:55 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0FFED31B; Sun, 9 Feb 2020 21:35:54 -0800 (PST) Received: from [10.163.1.162] (unknown [10.163.1.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37C1D3F68F; Sun, 9 Feb 2020 21:35:34 -0800 (PST) Subject: Re: [PATCH V13] mm/debug: Add tests validating architecture page table helpers To: Andrew Morton Cc: kbuild test robot , kbuild-all@lists.01.org, linux-mm@kvack.org, Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , Ingo Molnar , Richard Henderson , Ivan Kokshaysky , Matt Turner , Mark Salter , Aurelien Jacquiot , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Paul Walmsley , Palmer Dabbelt , Guan Xuetao , Chris Zankel , Max Filippov , Qian Cai , linux-alpha@vger.kernel.org, linux-c6x-dev@linux-c6x.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@vger.kernel.org, linux-riscv@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <1580897674-16456-1-git-send-email-anshuman.khandual@arm.com> <202002060619.wEOdAZU1%lkp@intel.com> <78d3ce6b-e100-2561-6b09-124c29731d1a@arm.com> <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> From: Anshuman Khandual Message-ID: <955229f7-f161-f720-0e75-a3163f63817d@arm.com> Date: Mon, 10 Feb 2020 11:05:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/10/2020 10:22 AM, Andrew Morton wrote: > On Thu, 6 Feb 2020 13:49:35 +0530 Anshuman Khandual wrote: > >> >> On 02/06/2020 04:40 AM, kbuild test robot wrote: >>> Hi Anshuman, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on powerpc/next] >>> [also build test ERROR on s390/features linus/master arc/for-next v5.5] >>> [cannot apply to mmotm/master tip/x86/core arm64/for-next/core next-20200205] >>> [if your patch is applied to the wrong git tree, please drop us a note to help >>> improve the system. BTW, we also suggest to use '--base' option to specify the >>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982] >>> >>> url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-debug-Add-tests-validating-architecture-page-table-helpers/20200205-215507 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next >>> config: ia64-allmodconfig (attached as .config) >>> compiler: ia64-linux-gcc (GCC) 7.5.0 >>> reproduce: >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # save the attached .config to linux build tree >>> GCC_VERSION=7.5.0 make.cross ARCH=ia64 >>> >>> If you fix the issue, kindly add following tag >>> Reported-by: kbuild test robot >>> >>> All error/warnings (new ones prefixed by >>): >>> >>> In file included from include/asm-generic/pgtable-nopud.h:8:0, >>> from arch/ia64/include/asm/pgtable.h:586, >>> from include/linux/mm.h:99, >>> from include/linux/highmem.h:8, >>> from mm/debug_vm_pgtable.c:14: >>> mm/debug_vm_pgtable.c: In function 'pud_clear_tests': >>>>> include/asm-generic/pgtable-nop4d-hack.h:47:32: error: implicit declaration of function '__pgd'; did you mean '__p4d'? [-Werror=implicit-function-declaration] >>> #define __pud(x) ((pud_t) { __pgd(x) }) >>> ^ >>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>> pud = __pud(pud_val(pud) | RANDOM_ORVALUE); >>> ^~~~~ >>>>> include/asm-generic/pgtable-nop4d-hack.h:47:22: warning: missing braces around initializer [-Wmissing-braces] >>> #define __pud(x) ((pud_t) { __pgd(x) }) >>> ^ >>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>> pud = __pud(pud_val(pud) | RANDOM_ORVALUE); >>> ^~~~~ >>> cc1: some warnings being treated as errors >> >> This build failure is expected now given that we have allowed DEBUG_VM_PGTABLE >> with EXPERT without platform requiring ARCH_HAS_DEBUG_VM_PGTABLE. This problem >> i.e build failure caused without a platform __pgd(), is known to exist both on >> ia64 and arm (32bit) platforms. Please refer https://lkml.org/lkml/2019/9/24/314 >> for details where this was discussed earlier. >> > > I'd prefer not to merge a patch which is known to cause build > regressions. Is there some temporary thing we can do to prevent these > errors until arch maintainers(?) get around to implementing the > long-term fixes? We could explicitly disable CONFIG_DEBUG_VM_PGTABLE on ia64 and arm platforms which will ensure that others can still use the EXPERT path. config DEBUG_VM_PGTABLE bool "Debug arch page table for semantics compliance" depends on MMU depends on !(IA64 || ARM) depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT default n if !ARCH_HAS_DEBUG_VM_PGTABLE default y if DEBUG_VM