From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E240C433F5 for ; Wed, 16 Feb 2022 11:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75D056B0071; Wed, 16 Feb 2022 06:16:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70C636B0073; Wed, 16 Feb 2022 06:16:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FCBE6B0074; Wed, 16 Feb 2022 06:16:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 52A206B0071 for ; Wed, 16 Feb 2022 06:16:51 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 13618180AC337 for ; Wed, 16 Feb 2022 11:16:51 +0000 (UTC) X-FDA: 79148390622.19.FF7D2BA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id 6F71A100010 for ; Wed, 16 Feb 2022 11:16:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E6766212C0; Wed, 16 Feb 2022 11:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645010208; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xamDngz84UWWOYTwcGYy9/wM5Fem6zTjMXuclkY3poc=; b=n4sVdU2+b5z0wXITqOJHUvvpPsQ1YgOanWlN7iWwltTImmnj7/dGuG6hevkHYeBW0ew+Z7 FNSjp+5mqb1Ab2b+pm66pxGJ5kO9pUWBnRy+PQQDP+UUCsPpXT2th5M4sODu/PkKe2LpLn ZU/vPpfA2JesRXwgJg0K4xsaKHO7Utc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645010208; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xamDngz84UWWOYTwcGYy9/wM5Fem6zTjMXuclkY3poc=; b=UYJM8mnd9kTHbIvijySHuu5aoW8olvhYHvY0OP/F1wqlMue/KaG19bH5POJFF4syHLewMo +1a2yWn2yR0MCHCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C74A313ADB; Wed, 16 Feb 2022 11:16:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lk8OMCDdDGLxKAAAMHmgww (envelope-from ); Wed, 16 Feb 2022 11:16:48 +0000 Message-ID: <95a205bc-fd35-565e-5597-deaadbf8b98a@suse.cz> Date: Wed, 16 Feb 2022 12:16:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 1/5] mm/page_alloc: Fetch the correct pcp buddy during bulk free Content-Language: en-US To: Mel Gorman , Andrew Morton Cc: Aaron Lu , Dave Hansen , Michal Hocko , Jesper Dangaard Brouer , LKML , Linux-MM References: <20220215145111.27082-1-mgorman@techsingularity.net> <20220215145111.27082-2-mgorman@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20220215145111.27082-2-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6F71A100010 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n4sVdU2+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UYJM8mnd; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: gttwunctw671afcjnsera4yph3ag5rr1 X-HE-Tag: 1645010210-474695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/15/22 15:51, Mel Gorman wrote: > free_pcppages_bulk() prefetches buddies about to be freed but the > order must also be passed in as PCP lists store multiple orders. > > Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists") > Signed-off-by: Mel Gorman Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3589febc6d31..08de32cfd9bb 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1432,10 +1432,10 @@ static bool bulkfree_pcp_prepare(struct page *page) > } > #endif /* CONFIG_DEBUG_VM */ > > -static inline void prefetch_buddy(struct page *page) > +static inline void prefetch_buddy(struct page *page, unsigned int order) > { > unsigned long pfn = page_to_pfn(page); > - unsigned long buddy_pfn = __find_buddy_pfn(pfn, 0); > + unsigned long buddy_pfn = __find_buddy_pfn(pfn, order); > struct page *buddy = page + (buddy_pfn - pfn); > > prefetch(buddy); > @@ -1512,7 +1512,7 @@ static void free_pcppages_bulk(struct zone *zone, int count, > * prefetch buddy for the first pcp->batch nr of pages. > */ > if (prefetch_nr) { > - prefetch_buddy(page); > + prefetch_buddy(page, order); > prefetch_nr--; > } > } while (count > 0 && --batch_free && !list_empty(list));