[PATCH] mm/filemap: Fix a typo in comment "unneccssary"->"unnecessary"

[PATCH] mm/filemap: Fix a typo in comment "unneccssary"->"unnecessary"

[Ethon Paul]

There is a typo in comment, fix it.

Signed-off-by: Ethon Paul <ethp@qq.com>
---
 mm/filemap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 23a051a7ef0f..de6d01a519e4 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1259,7 +1259,7 @@ EXPORT_SYMBOL_GPL(add_page_wait_queue);
  * instead.
  *
  * The read of PG_waiters has to be after (or concurrently with) PG_locked
- * being cleared, but a memory barrier should be unneccssary since it is
+ * being cleared, but a memory barrier should be unnecessary since it is
  * in the same byte as PG_locked.
  */
 static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem)
-- 
2.24.1 (Apple Git-126)

Re: [PATCH] mm/filemap: Fix a typo in comment "unneccssary"->"unnecessary"

[Matthew Wilcox]

On Sat, Apr 11, 2020 at 02:51:41PM +0800, Ethon Paul wrote:
> @@ -1259,7 +1259,7 @@ EXPORT_SYMBOL_GPL(add_page_wait_queue);
>   * instead.
>   *
>   * The read of PG_waiters has to be after (or concurrently with) PG_locked
> - * being cleared, but a memory barrier should be unneccssary since it is
> + * being cleared, but a memory barrier should be unnecessary since it is
>   * in the same byte as PG_locked.
>   */
>  static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem)

This will conflict with the patch series I sent here:
<20200326122429.20710-1-willy@infradead.org>

which deletes the entire comment.

Re: [PATCH] mm/filemap: Fix a typo in comment "unneccssary"->"unnecessary"

[Ralph Campbell]

On 4/10/20 11:51 PM, Ethon Paul wrote:
> There is a typo in comment, fix it.
> 
> Signed-off-by: Ethon Paul <ethp@qq.com>

Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>

> ---
>   mm/filemap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 23a051a7ef0f..de6d01a519e4 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1259,7 +1259,7 @@ EXPORT_SYMBOL_GPL(add_page_wait_queue);
>    * instead.
>    *
>    * The read of PG_waiters has to be after (or concurrently with) PG_locked
> - * being cleared, but a memory barrier should be unneccssary since it is
> + * being cleared, but a memory barrier should be unnecessary since it is
>    * in the same byte as PG_locked.
>    */
>   static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem)
> 

Re: [PATCH] mm/filemap: Fix a typo in comment "unneccssary"->"unnecessary"

[Matthew Wilcox]

On Wed, Apr 15, 2020 at 11:36:34AM -0700, Ralph Campbell wrote:
> 
> On 4/10/20 11:51 PM, Ethon Paul wrote:
> > There is a typo in comment, fix it.
> > 
> > Signed-off-by: Ethon Paul <ethp@qq.com>
> 
> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>

NAK.  See earlier response.

Re: [PATCH] mm/filemap: Fix a typo in comment "unneccssary"->"unnecessary"

[Ralph Campbell]

On 4/15/20 11:37 AM, Matthew Wilcox wrote:
> On Wed, Apr 15, 2020 at 11:36:34AM -0700, Ralph Campbell wrote:
>>
>> On 4/10/20 11:51 PM, Ethon Paul wrote:
>>> There is a typo in comment, fix it.
>>>
>>> Signed-off-by: Ethon Paul <ethp@qq.com>
>>
>> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> 
> NAK.  See earlier response.

Oops. Sorry about that.
I was looking at 5.7.0-rc1 and forgot about your pending change that makes this
unnecessary. :-)