From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Cc: David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@kernel.org>,
isimatu.yasuaki@jp.fujitsu.com
Subject: Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node()
Date: Tue, 25 Jul 2017 19:15:42 +0800 [thread overview]
Message-ID: <96d20c3c-8f4f-416e-edb7-7bc36fc3827b@cn.fujitsu.com> (raw)
In-Reply-To: <87d18o7uie.fsf@concordia.ellerman.id.au>
Hi Michael,
At 07/25/2017 05:09 PM, Michael Ellerman wrote:
> Dou Liyang <douly.fnst@cn.fujitsu.com> writes:
>
>> ... initializes local parameters "p_node" & "parent" for
>> register_node().
>>
>> But, register_node() does not use them.
>>
>> Remove the related code of "parent" node, cleanup __register_one_node()
>> and register_node().
>>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: David Rientjes <rientjes@google.com>
>> Cc: Michal Hocko <mhocko@kernel.org>
>> Cc: isimatu.yasuaki@jp.fujitsu.com
>> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
>> Acked-by: David Rientjes <rientjes@google.com>
>> ---
>> V1 --> V2:
>> Rebase it on
>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
>>
>> drivers/base/node.c | 9 ++-------
>> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> That appears to be the last user of parent_node().
Oops, yes, it is the last one.
>
> Can we start removing it from the topology.h headers for each arch?
>
Yes, I think so.
Thanks,
dou.
> cheers
>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-07-25 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 2:57 [PATCH v2] mm: Drop useless local parameters of __register_one_node() Dou Liyang
2017-06-29 11:12 ` Michal Hocko
2017-06-29 11:58 ` Dou Liyang
2017-06-29 12:11 ` Michal Hocko
2017-07-25 9:09 ` Michael Ellerman
2017-07-25 11:15 ` Dou Liyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96d20c3c-8f4f-416e-edb7-7bc36fc3827b@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).