From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E560BC004C9 for ; Tue, 7 May 2019 20:47:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 96DC720449 for ; Tue, 7 May 2019 20:47:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96DC720449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44A706B0007; Tue, 7 May 2019 16:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FA666B0008; Tue, 7 May 2019 16:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29B2D6B000A; Tue, 7 May 2019 16:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by kanga.kvack.org (Postfix) with ESMTP id 0735F6B0007 for ; Tue, 7 May 2019 16:47:47 -0400 (EDT) Received: by mail-qk1-f200.google.com with SMTP id v6so1669011qkh.6 for ; Tue, 07 May 2019 13:47:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QhTTPOEpvPT4kSMIPE5efueEW5gralwzrjv9bBcqYbI=; b=k53EXbveiQuXYw7+dk2/GnKL5pC7OdQYY7+P0s2KtodrVi81zeO+BSe4/wIJofkqT9 /SaKhwbA+Xf1UzWJuT8CRwtcCiI1TTECAM9wheC3wv1YyFDrWNlrjI+hadOmcLm0itO/ sYRgQNprSiNVeCVakCMOLT3zt/kZkCEKw7AXW7AdBJ8Y0mG4/ahGM4VDZ9NIEb4bSLlt r6TUrQHG0w9wUCaob/pySoYL2QVGlLQNNx6oUySzrwghoYLY0KfHWjqPNPOQ/BGm1Rf7 UPpDtHQKe9QQKr/S1R22s7H/Bpf34jDwSkDyvAOaovqEYhCegqY983ibh4Nx9vOT7fG2 zGIw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAUX4crG8A62uFkH5Z/qS5Ap1HVUdFvJg6iFbNSQrEfKtRTiByXk TQ6DLPZh5RtkPKSKZGAZbNs3iOgTmfgBQWqaRRRSYAsH8e8w5LiPpXs6jQvsaMq6a3QrG2PY8cs H3vDaS4UPgMJTOowFMXhZt1BnLOq+6BGCxEFzlwm3la2D9YQ2EWDuib6uPss6yFT8Sg== X-Received: by 2002:a37:8941:: with SMTP id l62mr25641397qkd.291.1557262066815; Tue, 07 May 2019 13:47:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzl+iHFBjCmcfB+MNyCz4lxQCRYVTV9bIQhgLw4RcBQEzrTL5cslcFPGxze0BctCuckLm41 X-Received: by 2002:a37:8941:: with SMTP id l62mr25641371qkd.291.1557262066307; Tue, 07 May 2019 13:47:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557262066; cv=none; d=google.com; s=arc-20160816; b=CS5uU/OLVuFtAoPq6uIG34UfWL0dn1TxzzD0v8Z4wNy1cpv/8fCy1z1V5+HBzSBBy+ +dYunZkBP6wHu7i2p9akVjsbD1CTVUDLeeznl3o03n7FGnDocLBS5ATq5+FgUO5GRRca piH0SSi61PU1AJ7tEHcWBm7ulRGBTdqP5to+vdp6PV/qzArrlZacNmFPZ5II0p2dF/i7 CZzaIJXc5Xezm4cz0UJUNsY6eybx/qZITFlLo7kYDbrznZ/IGcmI/FVZKU7GMXAyEEGa J5GHdGZ7HRRmcwxyB6f+bz+maAqvp0HLf8ASU87BjVLE7gyjdJcbP/pjoIYHomRb7xgb pjkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=QhTTPOEpvPT4kSMIPE5efueEW5gralwzrjv9bBcqYbI=; b=oOMek+oytpUpaKGLH6SsWxcqwJwAKH8ctkKijrTS0UhXhfw9CqHMjGAzkxHfDzp4uX tukQ02cPt+Cc4tPFreZMY2FHsoMUllnUCT48iBxP1sjnPqM8M/ug9bJ/w/aL02Un4+EI eo+allSnQ4PIVq6JnWTqa9Okxkum5KMBA+xqXRmCGfBw0+qvMpar/j02l0bdXXYRruNZ qspc4pNzOnIeFRLnbQrYzc71t6qKBrJmxfUGf15WP28lrKmeRbaYxA63N9nKmSTYUhMw 3gINtL/haK8C1MAvcs/0r1ganNfecZ1pLNugbiiQOMk/NLVt5ToeJRliMiw4YJjML6wR nNlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id j8si3521827qtc.390.2019.05.07.13.47.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 May 2019 13:47:46 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B8256698A; Tue, 7 May 2019 20:47:45 +0000 (UTC) Received: from [10.36.116.95] (ovpn-116-95.ams2.redhat.com [10.36.116.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7013600D4; Tue, 7 May 2019 20:47:42 +0000 (UTC) Subject: Re: [PATCH v2 2/8] s390x/mm: Implement arch_remove_memory() To: Dan Williams Cc: Linux MM , Linux Kernel Mailing List , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , Andrew Morton , Martin Schwidefsky , Heiko Carstens , Michal Hocko , Mike Rapoport , Vasily Gorbik , Oscar Salvador References: <20190507183804.5512-1-david@redhat.com> <20190507183804.5512-3-david@redhat.com> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <97a6a2ab-0e8b-d403-ca39-ffa4425e15a5@redhat.com> Date: Tue, 7 May 2019 22:47:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 07 May 2019 20:47:45 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.05.19 22:46, Dan Williams wrote: > On Tue, May 7, 2019 at 11:38 AM David Hildenbrand wrote: >> >> Will come in handy when wanting to handle errors after >> arch_add_memory(). >> >> Cc: Martin Schwidefsky >> Cc: Heiko Carstens >> Cc: Andrew Morton >> Cc: Michal Hocko >> Cc: Mike Rapoport >> Cc: David Hildenbrand >> Cc: Vasily Gorbik >> Cc: Oscar Salvador >> Signed-off-by: David Hildenbrand >> --- >> arch/s390/mm/init.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c >> index 31b1071315d7..1e0cbae69f12 100644 >> --- a/arch/s390/mm/init.c >> +++ b/arch/s390/mm/init.c >> @@ -237,12 +237,13 @@ int arch_add_memory(int nid, u64 start, u64 size, >> void arch_remove_memory(int nid, u64 start, u64 size, >> struct vmem_altmap *altmap) >> { >> - /* >> - * There is no hardware or firmware interface which could trigger a >> - * hot memory remove on s390. So there is nothing that needs to be >> - * implemented. >> - */ >> - BUG(); >> + unsigned long start_pfn = start >> PAGE_SHIFT; >> + unsigned long nr_pages = size >> PAGE_SHIFT; >> + struct zone *zone; >> + >> + zone = page_zone(pfn_to_page(start_pfn)); > > Does s390 actually support passing in an altmap? If 'yes', I think it > also needs the vmem_altmap_offset() fixup like x86-64: > > /* With altmap the first mapped page is offset from @start */ > if (altmap) > page += vmem_altmap_offset(altmap); > > ...but I suspect it does not support altmap since > arch/s390/mm/vmem.c::vmemmap_populate() does not arrange for 'struct > page' capacity to be allocated out of an altmap defined page pool. > > I think it would be enough to disallow any arch_add_memory() on s390 > where @altmap is non-NULL. At least until s390 gains ZONE_DEVICE > support and can enable the pmem use case. > As far as I know, it doesn't yet, however I guess this could change once virtio-pmem is supported? Thanks! -- Thanks, David / dhildenb