From: Miaohe Lin <linmiaohe@huawei.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
David Hildenbrand <david@redhat.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/hugetlb: avoid unnecessary hugetlb_acct_memory() call
Date: Fri, 15 Jan 2021 10:04:19 +0800 [thread overview]
Message-ID: <9841241e-eb8f-9b49-8d2d-d84effda8ba4@huawei.com> (raw)
In-Reply-To: <b7587d72-fb5b-4e0f-4fa0-d63e035e521c@oracle.com>
Hi:
On 2021/1/15 3:16, Mike Kravetz wrote:
> On 1/14/21 4:32 AM, David Hildenbrand wrote:
>> On 14.01.21 12:31, Miaohe Lin wrote:
>>> When gbl_reserve is 0, hugetlb_acct_memory() will do nothing except holding
>>> and releasing hugetlb_lock.
>>
>> So, what's the deal then? Adding more code?
>>
>> If this is a performance improvement, we should spell it out. Otherwise
>> I don't see a real benefit of this patch.
>>
>
> Thanks for finding/noticing this.
>
> As David points out, the commit message should state that this is a
> performance improvement. Mention that such a change avoids an unnecessary
> hugetlb_lock lock/unlock cycle. You can also mention that this unnecessary
> lock cycle is happening on 'most' hugetlb munmap operations.
>
My bad. I should spell this out explicitly. Many thanks for both of you.
>>>
>>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>>> ---
>>> mm/hugetlb.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>>> index 737b2dce19e6..fe2da9ad6233 100644
>>> --- a/mm/hugetlb.c
>>> +++ b/mm/hugetlb.c
>>> @@ -5241,7 +5241,8 @@ long hugetlb_unreserve_pages(struct inode *inode, long start, long end,
>>> * reservations to be released may be adjusted.
>>> */
>>> gbl_reserve = hugepage_subpool_put_pages(spool, (chg - freed));
>>> - hugetlb_acct_memory(h, -gbl_reserve);
>>> + if (gbl_reserve)
>>> + hugetlb_acct_memory(h, -gbl_reserve);
>
> It is true that gbl_reserve is likely to be 0 in this code path. However,
> there are other code paths where hugetlb_acct_memory is called with a delta
> value of 0 as well. I would rather see a simple check at the beginning of
> hugetlb_acct_memory like.
>
> if (!delta)
> return 0;
>
Sounds good. Will do it in v2. Many thanks again.
next prev parent reply other threads:[~2021-01-15 2:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 11:31 [PATCH] mm/hugetlb: avoid unnecessary hugetlb_acct_memory() call Miaohe Lin
2021-01-14 12:32 ` David Hildenbrand
2021-01-14 19:16 ` Mike Kravetz
2021-01-15 2:04 ` Miaohe Lin [this message]
2021-01-15 8:47 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9841241e-eb8f-9b49-8d2d-d84effda8ba4@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).