From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CAAC433DB for ; Wed, 24 Feb 2021 21:18:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B58D164F09 for ; Wed, 24 Feb 2021 21:18:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B58D164F09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF7A36B0006; Wed, 24 Feb 2021 16:18:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA77B6B006C; Wed, 24 Feb 2021 16:18:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBDFB6B006E; Wed, 24 Feb 2021 16:18:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id A6ED76B0006 for ; Wed, 24 Feb 2021 16:18:40 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6517C18025C12 for ; Wed, 24 Feb 2021 21:18:40 +0000 (UTC) X-FDA: 77854425600.07.C93E4A5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id AF5BAA00051A for ; Wed, 24 Feb 2021 21:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=NkdOm/Wr6jKULUuvilCEerFUVq06JLI/C+YFLMpTzlg=; b=GRvuPBWYZjghamXLNw/rwQeqPD bvWheuMahqIIAqHFNEVLVk3cuz/1FLMVKOIYKzwgIy64AY4INdsw2uXL6UvyZGu7dAyLKm7QRQ6+9 KNGqGfQW5bxVCIwdOhHkUJ6sxpatM0SQINFPXPCUfbJtmkiR4i9ticBK7ZycSOJT0PHCOqTB7sMT9 1lgwatkmDYMVtftUTC2W5hFXAXutWcsLv97UTi6fZZWvDOJXHLwfB1DDuoVjGrPmjz0q1LNuxzGmn iTJvx1IIIf8A7qs4ztfSwZXTEEUD6oRiyx+G7CyIyYDeL05/J4TiKxNile6KioFmdvkxXtfLSEyVT lyfvtJNQ==; Received: from [2601:1c0:6280:3f0::6d64] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lF1Y9-009trw-Jq; Wed, 24 Feb 2021 21:18:27 +0000 Subject: Re: [linux-next:master 11942/12503] drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' From: Randy Dunlap To: Nick Desaulniers Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Daniel Vetter References: <202102242016.MJskK6hp-lkp@intel.com> <97716bb9-6aca-d7e6-e390-1b9d3a0b99a8@infradead.org> <3628bb0f-0790-2a18-93e5-be244d32be53@infradead.org> Message-ID: <99802c78-c809-2b02-b79e-c1fc7885e588@infradead.org> Date: Wed, 24 Feb 2021 13:18:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: f1t5r4bmqug7wy6k6wa9rke3afp4yrjm X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AF5BAA00051A Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614201517-278766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/24/21 1:05 PM, Randy Dunlap wrote: > On 2/24/21 1:02 PM, Randy Dunlap wrote: >> On 2/24/21 12:42 PM, Nick Desaulniers wrote: >>> On Wed, Feb 24, 2021 at 12:03 PM Randy Dunlap wrote: >>>> >>>> On 2/24/21 4:46 AM, kernel test robot wrote: >>>>> Hi Randy, >>>>> >>>>> FYI, the error/warning still remains. >>>>> >>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>>>> head: 577c283560fe8a81a23a95654c6d13e8412d22f1 >>>>> commit: bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 [11942/12503] fbdev: atyfb: add stubs for aty_{ld,st}_lcd() >>>>> config: arm64-randconfig-r004-20210223 (attached as .config) >>>>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f14a14dd2564703db02f80c00db8ae492b594f77) >>>>> reproduce (this is a W=1 build): >>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>>> chmod +x ~/bin/make.cross >>>>> # install arm64 cross compiling tool for clang build >>>>> # apt-get install binutils-aarch64-linux-gnu >>>>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 >>>>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>>>> git fetch --no-tags linux-next master >>>>> git checkout bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 >>>>> # save the attached .config to linux build tree >>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 >>>>> >>>>> If you fix the issue, kindly add following tag as appropriate >>>>> Reported-by: kernel test robot >>>>> >>>>> All warnings (new ones prefixed by >>): >>>>> >>>>>>> drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' [-Wmissing-prototypes] >>>>> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >>>>> ^ >>>>> drivers/video/fbdev/aty/atyfb_base.c:180:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>>>> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >>>>> ^ >>>>> static >>>>>>> drivers/video/fbdev/aty/atyfb_base.c:183:5: warning: no previous prototype for function 'aty_ld_lcd' [-Wmissing-prototypes] >>>>> u32 aty_ld_lcd(int index, const struct atyfb_par *par) >>>>> ^ >>>>> drivers/video/fbdev/aty/atyfb_base.c:183:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>>>> u32 aty_ld_lcd(int index, const struct atyfb_par *par) >>>>> ^ >>>>> static >>>>> 2 warnings generated. >>>>> >>>> >>>> These 2 functions are also used/usable (depending on CONFIG options) in >>>> mach64_ct.c so they can't be static. >>>> >>>> AFAIK, we don't make functions have different qualifiers depending on >>>> config options. >>> >>> Is there a shared header included by both mach64_ct.c and atyfb_base.c >>> you could provide a declaration in, that way should the definition >>> change we'd catch such a change in order to not break the callers? >>> >> >> atyfb.h: >> >> #if defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) || \ >> defined (CONFIG_FB_ATY_BACKLIGHT) >> extern void aty_st_lcd(int index, u32 val, const struct atyfb_par *par); >> extern u32 aty_ld_lcd(int index, const struct atyfb_par *par); >> #endif >> >> so it's already there unless the .config did not include those #ifdef CONFIG_s. >> I'll recheck that. > > OK, none of those 3 kconfig symbols is set. I'll check again where the > usage is. I think I just need to make them always visible in atyfb.h. I'll test that and then send a patch. ~Randy