From: "Zi Yan" <ziy@nvidia.com>
To: "Miaohe Lin" <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, willy@infradead.org,
william.kucharski@oracle.com, vbabka@suse.cz, peterx@redhat.com,
yulei.kernel@gmail.com, walken@google.com,
aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com,
thomas_os@shipmail.org, yang.shi@linux.alibaba.com,
richard.weiyang@linux.alibaba.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3 3/6] mm/huge_memory.c: rework the function do_huge_pmd_numa_page() slightly
Date: Thu, 18 Mar 2021 10:04:56 -0400 [thread overview]
Message-ID: <9BC36D5A-991A-41D0-A5CF-40A0E908E630@nvidia.com> (raw)
In-Reply-To: <20210318122722.13135-4-linmiaohe@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On 18 Mar 2021, at 8:27, Miaohe Lin wrote:
> The current code that checks if migrating misplaced transhuge page is
> needed is pretty hard to follow. Rework it and add a comment to make
> its logic more clear and improve readability.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/huge_memory.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
—
Best Regards,
Yan Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2021-03-18 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:27 [PATCH v3 0/6] Some cleanups for huge_memory Miaohe Lin
2021-03-18 12:27 ` [PATCH v3 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() Miaohe Lin
2021-03-18 12:27 ` [PATCH v3 2/6] mm/huge_memory.c: make get_huge_zero_page() return bool Miaohe Lin
2021-03-18 14:00 ` Zi Yan
2021-03-18 12:27 ` [PATCH v3 3/6] mm/huge_memory.c: rework the function do_huge_pmd_numa_page() slightly Miaohe Lin
2021-03-18 14:04 ` Zi Yan [this message]
2021-03-18 12:27 ` [PATCH v3 4/6] mm/huge_memory.c: remove redundant PageCompound() check Miaohe Lin
2021-03-18 12:27 ` [PATCH v3 5/6] mm/huge_memory.c: remove unused macro TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG Miaohe Lin
2021-03-18 14:12 ` Zi Yan
2021-03-18 12:27 ` [PATCH v3 6/6] mm/huge_memory.c: use helper function migration_entry_to_page() Miaohe Lin
2021-03-18 15:07 ` [PATCH v3 0/6] Some cleanups for huge_memory Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BC36D5A-991A-41D0-A5CF-40A0E908E630@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=thomas_os@shipmail.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=yulei.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).