From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA6DC4361B for ; Sat, 19 Dec 2020 13:15:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B26F323AC2 for ; Sat, 19 Dec 2020 13:15:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B26F323AC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C1C16B005D; Sat, 19 Dec 2020 08:15:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4721A6B0068; Sat, 19 Dec 2020 08:15:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 312F16B006C; Sat, 19 Dec 2020 08:15:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 1A6646B005D for ; Sat, 19 Dec 2020 08:15:42 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D7277364D for ; Sat, 19 Dec 2020 13:15:41 +0000 (UTC) X-FDA: 77610078882.26.seat07_630539d27446 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id B6F2C1804A302 for ; Sat, 19 Dec 2020 13:15:41 +0000 (UTC) X-HE-Tag: seat07_630539d27446 X-Filterd-Recvd-Size: 5202 Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Dec 2020 13:15:40 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJDE9Z6176966; Sat, 19 Dec 2020 13:15:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=Dcsogiio8SJnRZOaSCyO6DdwNytM21g2JOcWZx/KC6s=; b=bDewbChdLY1PMBBaANCY/MF8cftTUh+XWuWPD5K+qG+fjyFsgASPsC87Q/ikSbRl/Xii 384kRnwVueFY9fMcWZKeWJVHw1U3OiM/YOudxzeJTAB61gD4cKnkSJc7AEzx75sp7FHm ngxoANLvNUjtGfVfhiPLAGuZOju3zbHaVpUgf47Hl4bQVqaxqoP03fC53s77c8ZegjRN tveYT2QmqBEcZxq1GdxoJ6Br1HtHTy8mqSUS6SouFamgG+sLewTknjn4qIERjeSsGLnf qnPpGWkfwMU2sGN012ESmeuYBzkdcn9C8tfXk+Qn44oCfvUG4HD8UZCOmUDUNLDpSEvq MQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 35h71as0a1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Dec 2020 13:15:34 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJDALHK027030; Sat, 19 Dec 2020 13:15:33 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 35h6mrwd8n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Dec 2020 13:15:33 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0BJDFVTL007615; Sat, 19 Dec 2020 13:15:31 GMT Received: from [192.168.1.188] (/89.180.84.11) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 19 Dec 2020 05:15:31 -0800 Subject: Re: [PATCH RFC 8/9] RDMA/umem: batch page unpin in __ib_mem_release() From: Joao Martins To: Jason Gunthorpe Cc: linux-mm@kvack.org, Dan Williams , Ira Weiny , linux-nvdimm@lists.01.org, Matthew Wilcox , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton References: <20201208172901.17384-1-joao.m.martins@oracle.com> <20201208172901.17384-10-joao.m.martins@oracle.com> <20201208192935.GA1908088@ziepe.ca> <543363df-cefd-93e9-1ca1-9256e910a915@oracle.com> Message-ID: <9a2e7772-905c-54f3-2116-25e14e42a3aa@oracle.com> Date: Sat, 19 Dec 2020 13:15:27 +0000 MIME-Version: 1.0 In-Reply-To: <543363df-cefd-93e9-1ca1-9256e910a915@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190097 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/9/20 10:59 AM, Joao Martins wrote: > On 12/8/20 7:29 PM, Jason Gunthorpe wrote: >> On Tue, Dec 08, 2020 at 05:29:00PM +0000, Joao Martins wrote: >> >>> static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int dirty) >>> { >>> + bool make_dirty = umem->writable && dirty; >>> + struct page **page_list = NULL; >>> struct sg_page_iter sg_iter; >>> + unsigned long nr = 0; >>> struct page *page; >>> >>> + page_list = (struct page **) __get_free_page(GFP_KERNEL); >> >> Gah, no, don't do it like this! >> >> Instead something like: >> >> for_each_sg(umem->sg_head.sgl, sg, umem->nmap, i) >> unpin_use_pages_range_dirty_lock(sg_page(sg), sg->length/PAGE_SIZE, >> umem->writable && dirty); >> >> And have the mm implementation split the contiguous range of pages into >> pairs of (compound head, ntails) with a bit of maths. >> > Got it :) > > I was trying to avoid another exported symbol. > > Albeit upon your suggestion below, it doesn't justify the efficiency/clearness lost. > This more efficient suggestion of yours leads to a further speed up from: 1073 rounds in 5.004 sec: 4663.622 usec / round (hugetlbfs) to 1370 rounds in 5.003 sec: 3651.562 usec / round (hugetlbfs) Right after I come back from holidays I will follow up with this series in separate. Joao