From: John Hubbard <jhubbard@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
David Hildenbrand <david@redhat.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v4 1/5] mm: Fix invalid page pointer returned with FOLL_PIN gups
Date: Sun, 6 Feb 2022 21:19:35 -0800 [thread overview]
Message-ID: <9a5e9fac-7597-80b6-1cc8-9818b8ff73cd@nvidia.com> (raw)
In-Reply-To: <YfzU4Yh/1Oh7Dsw0@infradead.org>
On 2/3/22 23:25, Christoph Hellwig wrote:
> On Thu, Feb 03, 2022 at 06:00:06PM -0800, John Hubbard wrote:
>> From: Peter Xu <peterx@redhat.com>
>>
>> Alex reported invalid page pointer returned with pin_user_pages_remote() from
>> vfio after upstream commit 4b6c33b32296 ("vfio/type1: Prepare for batched
>> pinning with struct vfio_batch").
>
> This commit message uses overly long lines all over.
I'll reflow it to 72 columns and post a v5 with the full set of
reviewed-by tags.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
I appreciate the reviews, from you and everyone, as always.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-02-07 5:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 2:00 [PATCH v4 0/5] mm/gup: some cleanups John Hubbard
2022-02-04 2:00 ` [PATCH v4 1/5] mm: Fix invalid page pointer returned with FOLL_PIN gups John Hubbard
2022-02-04 7:25 ` Christoph Hellwig
2022-02-07 5:19 ` John Hubbard [this message]
2022-02-04 11:42 ` Jan Kara
2022-02-04 2:00 ` [PATCH v4 2/5] mm/gup: follow_pfn_pte(): -EEXIST cleanup John Hubbard
2022-02-04 7:25 ` Christoph Hellwig
2022-02-04 11:41 ` Jan Kara
2022-02-04 2:00 ` [PATCH v4 3/5] mm/gup: remove unused pin_user_pages_locked() John Hubbard
2022-02-04 2:00 ` [PATCH v4 4/5] mm: change lookup_node() to use get_user_pages_fast() John Hubbard
2022-02-04 7:27 ` Christoph Hellwig
2022-02-04 2:00 ` [PATCH v4 5/5] mm/gup: remove unused get_user_pages_locked() John Hubbard
2022-02-04 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5e9fac-7597-80b6-1cc8-9818b8ff73cd@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=imbrenda@linux.ibm.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas.bulwahn@gmail.com \
--cc=peterx@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).