From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-snps-arc@lists.infradead.org, x86@kernel.org,
linux-arch@vger.kernel.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Vineet Gupta <vgupta@synopsys.com>,
Mike Rapoport <rppt@linux.ibm.com>, Qian Cai <cai@lca.pw>
Subject: Re: [PATCH v3 08/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP
Date: Tue, 1 Sep 2020 11:55:30 +0530 [thread overview]
Message-ID: <9beaaf93-b2dd-6d56-7737-9f022760f246@linux.ibm.com> (raw)
In-Reply-To: <e7877a8d-b433-0cb4-50a7-631de0022c24@arm.com>
On 9/1/20 8:52 AM, Anshuman Khandual wrote:
>
>
> On 08/27/2020 01:34 PM, Aneesh Kumar K.V wrote:
>> Architectures like ppc64 use deposited page table while updating the huge pte
>> entries.
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> ---
>> mm/debug_vm_pgtable.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
>> index f9f6358899a8..0ce5c6a24c5b 100644
>> --- a/mm/debug_vm_pgtable.c
>> +++ b/mm/debug_vm_pgtable.c
>> @@ -154,7 +154,7 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
>> static void __init pmd_advanced_tests(struct mm_struct *mm,
>> struct vm_area_struct *vma, pmd_t *pmdp,
>> unsigned long pfn, unsigned long vaddr,
>> - pgprot_t prot)
>> + pgprot_t prot, pgtable_t pgtable)
>> {
>> pmd_t pmd;
>>
>> @@ -165,6 +165,8 @@ static void __init pmd_advanced_tests(struct mm_struct *mm,
>> /* Align the address wrt HPAGE_PMD_SIZE */
>> vaddr = (vaddr & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE;
>>
>> + pgtable_trans_huge_deposit(mm, pmdp, pgtable);
>> +
>> pmd = pmd_mkhuge(pfn_pmd(pfn, prot));
>> set_pmd_at(mm, vaddr, pmdp, pmd);
>> pmdp_set_wrprotect(mm, vaddr, pmdp);
>> @@ -193,6 +195,8 @@ static void __init pmd_advanced_tests(struct mm_struct *mm,
>> pmdp_test_and_clear_young(vma, vaddr, pmdp);
>> pmd = READ_ONCE(*pmdp);
>> WARN_ON(pmd_young(pmd));
>> +
>> + pgtable = pgtable_trans_huge_withdraw(mm, pmdp);
>
> Should the call sites here be wrapped with __HAVE_ARCH_PGTABLE_DEPOSIT and
> __HAVE_ARCH_PGTABLE_WITHDRAW respectively. Though there are generic fallback
> definitions, wondering whether they are indeed essential for all platforms.
>
No, because Any page table helpers operating on pmd level THP can expect
a deposited page table.
__HAVE_ARCH_PGTABLE_DEPOSIT indicates that fallback to generic version.
>> }
>>
>> static void __init pmd_leaf_tests(unsigned long pfn, pgprot_t prot)
>> @@ -373,7 +377,7 @@ static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) { }
>> static void __init pmd_advanced_tests(struct mm_struct *mm,
>> struct vm_area_struct *vma, pmd_t *pmdp,
>> unsigned long pfn, unsigned long vaddr,
>> - pgprot_t prot)
>> + pgprot_t prot, pgtable_t pgtable)
>> {
>> }
>> static void __init pud_advanced_tests(struct mm_struct *mm,
>> @@ -1015,7 +1019,7 @@ static int __init debug_vm_pgtable(void)
>> pgd_clear_tests(mm, pgdp);
>>
>> pte_advanced_tests(mm, vma, ptep, pte_aligned, vaddr, prot);
>> - pmd_advanced_tests(mm, vma, pmdp, pmd_aligned, vaddr, prot);
>> + pmd_advanced_tests(mm, vma, pmdp, pmd_aligned, vaddr, prot, saved_ptep);
>> pud_advanced_tests(mm, vma, pudp, pud_aligned, vaddr, prot);
>> hugetlb_advanced_tests(mm, vma, ptep, pte_aligned, vaddr, prot);
>>
>>
>
> There is a checkpatch.pl warning here.
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #7:
> Architectures like ppc64 use deposited page table while updating the huge pte
>
> total: 0 errors, 1 warnings, 40 lines checked
>
I will ignore all these, because they are not really important IMHO.
-aneesh
next prev parent reply other threads:[~2020-09-01 6:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 8:04 [PATCH v3 00/13] mm/debug_vm_pgtable fixes Aneesh Kumar K.V
2020-08-27 8:04 ` [PATCH v3 01/13] powerpc/mm: Add DEBUG_VM WARN for pmd_clear Aneesh Kumar K.V
2020-09-01 3:12 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 02/13] powerpc/mm: Move setting pte specific flags to pfn_pte Aneesh Kumar K.V
2020-09-01 3:13 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 03/13] mm/debug_vm_pgtable/ppc64: Avoid setting top bits in radom value Aneesh Kumar K.V
2020-09-01 3:15 ` Anshuman Khandual
2020-09-01 6:21 ` Aneesh Kumar K.V
2020-09-01 7:32 ` Anshuman Khandual
2020-09-01 7:36 ` Aneesh Kumar K.V
2020-09-01 7:46 ` Anshuman Khandual
2020-09-01 7:55 ` Aneesh Kumar K.V
2020-09-02 3:45 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 04/13] mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge vmap support Aneesh Kumar K.V
2020-09-01 3:16 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 05/13] mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with CONFIG_NUMA_BALANCING Aneesh Kumar K.V
2020-09-01 3:18 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 06/13] mm/debug_vm_pgtable/THP: Mark the pte entry huge before using set_pmd/pud_at Aneesh Kumar K.V
2020-09-01 3:21 ` Anshuman Khandual
2020-09-01 6:23 ` Aneesh Kumar K.V
2020-08-27 8:04 ` [PATCH v3 07/13] mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update an existing pte entry Aneesh Kumar K.V
2020-08-27 8:04 ` [PATCH v3 08/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP Aneesh Kumar K.V
2020-09-01 3:22 ` Anshuman Khandual
2020-09-01 6:25 ` Aneesh Kumar K.V [this message]
2020-09-01 6:50 ` Christophe Leroy
2020-09-01 7:40 ` Aneesh Kumar K.V
2020-09-01 7:51 ` Christophe Leroy
2020-09-02 3:45 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 09/13] mm/debug_vm_pgtable/locks: Move non page table modifying test together Aneesh Kumar K.V
2020-09-01 3:41 ` Anshuman Khandual
2020-09-01 6:38 ` Aneesh Kumar K.V
2020-09-01 9:33 ` Anshuman Khandual
2020-09-01 9:36 ` Aneesh Kumar K.V
2020-09-01 9:58 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 10/13] mm/debug_vm_pgtable/locks: Take correct page table lock Aneesh Kumar K.V
2020-09-01 3:44 ` Anshuman Khandual
2020-08-27 8:04 ` [PATCH v3 11/13] mm/debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entries Aneesh Kumar K.V
2020-08-27 8:04 ` [PATCH v3 12/13] mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 Aneesh Kumar K.V
2020-09-01 4:03 ` Anshuman Khandual
2020-09-01 6:30 ` Aneesh Kumar K.V
2020-09-01 7:59 ` Christophe Leroy
2020-09-02 13:05 ` Anshuman Khandual
2020-09-02 13:20 ` Aneesh Kumar K.V
2020-08-27 8:04 ` [PATCH v3 13/13] mm/debug_vm_pgtable: populate a pte entry before fetching it Aneesh Kumar K.V
2020-08-27 12:17 ` kernel test robot
2020-09-01 3:25 ` Anshuman Khandual
2020-09-01 6:37 ` Aneesh Kumar K.V
2020-09-01 7:38 ` Anshuman Khandual
2020-09-01 9:58 ` Aneesh Kumar K.V
2020-09-02 3:49 ` Anshuman Khandual
2020-09-02 3:58 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9beaaf93-b2dd-6d56-7737-9f022760f246@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=cai@lca.pw \
--cc=christophe.leroy@c-s.fr \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rppt@linux.ibm.com \
--cc=vgupta@synopsys.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).