From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D13C4332F for ; Wed, 23 Nov 2022 23:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77AAE6B0071; Wed, 23 Nov 2022 18:40:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72B8B6B0072; Wed, 23 Nov 2022 18:40:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3A56B0074; Wed, 23 Nov 2022 18:40:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 50AB46B0071 for ; Wed, 23 Nov 2022 18:40:43 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1904CABB7A for ; Wed, 23 Nov 2022 23:40:43 +0000 (UTC) X-FDA: 80166329166.20.6FF5053 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf06.hostedemail.com (Postfix) with ESMTP id 80D0B180004 for ; Wed, 23 Nov 2022 23:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669246842; x=1700782842; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mcBURe4LzeYETeIQLGl6OG0wtQiOP6b+ev/9eJ+l754=; b=ngqRaDKzE4W0FXjFfPhPlMU6arGMzmCnfydr2iCAB4Pu+UZAwKWl6ta8 qvni3nfNTLB1uuIWod8VS2YtsJN03Rv6LCdWYsmX6N+C8CY3WYKFpYlW1 vpLZ8YDtr75CHJAqAJLrzb4NmdTy/CN0qNj/Qqxg3y3yfM/IeAFziUONS 3I1hc9bplY5BYId2pFOV0MgqB1dZA0sjECDeP2GwSfWBghCSxCJFOxu0Z ocXpsEwkwRYMSCMm9/64HRaFy6BMldmIIH/yqA9B1dYt+sTi2ZYheb/uR xhqybZGdvCq0bwq9cGQYhuQWmupicGpNphVma9PR8am0MXWWOK0V0Pj/J w==; X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="378437906" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="378437906" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 15:40:40 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="766893492" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="766893492" Received: from vcbudden-mobl3.amr.corp.intel.com (HELO [10.212.129.67]) ([10.212.129.67]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 15:40:39 -0800 Message-ID: <9c36d878-db83-5c0e-90f3-8f19dd25801c@intel.com> Date: Wed, 23 Nov 2022 15:40:37 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 15/20] x86/virt/tdx: Reserve TDX module global KeyID Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, peterz@infradead.org, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ngqRaDKz; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669246842; a=rsa-sha256; cv=none; b=cmDMNkjAsEkAl8xedJrFk1rUWbfC5hR/xD6yJNx8uf3jF4aHriEtdT1eAm+q9ZqeOPnqr3 HVG0QYVti1fHEamJrUlHE6iEM/EZsK5ytRTp7SUrtSN2ITV5sC8HEjGS4k2hq+MeneI2NH KOkhVLYAwedv2WtfFbAfdRfvv7lV14E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669246842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M0Gh8xJB/+wtic5Z8381qkRLGZA4BUbSwmxkidS25MA=; b=1FvZ+mjX0YUeBu+bUHkQJmnw2V3nBIfS4JNIqUDMnamFHvlKi5xPpU6HK5WgvE9agfR31/ sx0rOT/53gKYv4sgU/JmT5bUxwC4e+Z0FrMGfyYVwYjOZsPNSgntkvB0GIbEy14JSsuHg1 B8LKcpDfbZaX2hhTdWCBmzumO1AvNdM= X-Rspamd-Queue-Id: 80D0B180004 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ngqRaDKz; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam06 X-Stat-Signature: 5gibqnochdygeccrux115kmb9yridp7q X-HE-Tag: 1669246842-543168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/20/22 16:26, Kai Huang wrote: > @@ -1053,6 +1056,12 @@ static int init_tdx_module(void) > if (ret) > goto out_free_tdmrs; > > + /* > + * Reserve the first TDX KeyID as global KeyID to protect > + * TDX module metadata. > + */ > + tdx_global_keyid = tdx_keyid_start; This doesn't "reserve" squat. You could argue that it "picks", "chooses", or "designates" the 'tdx_global_keyid', but where is the "reservation"?