From: Qian Cai <qcai@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held
Date: Wed, 02 Dec 2020 18:39:06 -0500 [thread overview]
Message-ID: <9d854812b07d8a7516274ea47739158c34cfce08.camel@redhat.com> (raw)
In-Reply-To: <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org>
On Wed, 2020-12-02 at 15:15 -0800, Andrew Morton wrote:
> On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai <qcai@redhat.com> wrote:
>
> > We can't call kvfree() with a spin lock held, so defer it.
> >
>
> Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct
> allocatio
> n")
>
> Do you think it's worth a cc:stable? IOW, is this known to ever
> produce a warning?
Yes, it did trigger a might_sleep() warning.
prev parent reply other threads:[~2020-12-02 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 15:15 [PATCH] mm/swapfile: Do not sleep with a spin lock held Qian Cai
2020-12-02 23:15 ` Andrew Morton
2020-12-02 23:39 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d854812b07d8a7516274ea47739158c34cfce08.camel@redhat.com \
--to=qcai@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).