From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0871BC636CE for ; Mon, 19 Jul 2021 09:53:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 788D2611AE for ; Mon, 19 Jul 2021 09:53:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 788D2611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C62938D00FA; Mon, 19 Jul 2021 05:53:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEB378D00EC; Mon, 19 Jul 2021 05:53:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64A48D00FA; Mon, 19 Jul 2021 05:53:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 7E74A8D00EC for ; Mon, 19 Jul 2021 05:53:21 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 085881808F56A for ; Mon, 19 Jul 2021 09:53:20 +0000 (UTC) X-FDA: 78378874560.37.DF52B40 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf04.hostedemail.com (Postfix) with ESMTP id 0115250000A7 for ; Mon, 19 Jul 2021 09:53:18 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id g4-20020a17090ace84b029017554809f35so13714375pju.5 for ; Mon, 19 Jul 2021 02:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=E2tZE1Ed0aZpkrCfB99XZNU8SFfnSKYacY6RqWfb6v0=; b=WH2Ykao0CL8ffEEwvky53xOjUsbsh37gLm2+9Pd7OtE5goUtTklLM51bZXpzgkuglw hPZjP70D8RR/PKC9cvktg8Aoyvs0VvKOO/Wz8hIbtTzILSHgKhGZ22LPzl7IxkoJMqQd jsQk6Fs84EJs369DPBiQy/dFMNwZdSwaCsLdsc0kKaQ34Yufukf4SxiqJFUxFH4JivZQ +u99HXf8QYRYF/8ddNtDTSVEhWr3/X0+sLLIRWOfLAqInXwODZOfFGX7d9/RzxBU2qrI CeUPJWM3uDmbEegsZhDGe0rpDr3KRnC0LHNnVd7P4H6rvOM1wr7yWyLZwcqxkGq5n4s8 ITZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=E2tZE1Ed0aZpkrCfB99XZNU8SFfnSKYacY6RqWfb6v0=; b=U5TGOGOe6hZAJmeXzHZEUED+hu4ZhngkUSCsQkLg1jTjMr7BlwsntR4srThXjWc5h7 K44FeCT/3WE1RHAUguXTFSy+fgCQOnIK62YjF3uq+z2YI1oPDMGOaesJk6i/Gq0AJV65 pr4E9EXEJeG2rxrpoNYSd6M+JcMmDLdvPmtr6ReOK+bBTYocfJSGkHRmj/hZyTmh85cB 9vuWfD2vQE6d+SYhYXCEo0BdT6M35H1adoQZqCOsxhM4BrLUinR7MczUEUk/ZoBaWnHZ SdZ1JG4+MrzfD/KXKVjNMuNeZyydfrbol91qbDNMRAjfIOiku4GYI+6GVTPotw10+ccx y57g== X-Gm-Message-State: AOAM531dXlU8TFQXKHHZjGJuaMFeSmC4idkuisN6Cf7NL8GdYpTUZXcU CbGTu+ZO4QzXa1FMI2UVMCU+3A== X-Google-Smtp-Source: ABdhPJzE4kEpR1F76PMihUwTBGQTjf87c9UpFZlcNlaP9p/GUb1Ez01h+tYgDZRGl7H1xCbSbOJBiQ== X-Received: by 2002:a17:902:e14c:b029:129:d117:fa3d with SMTP id d12-20020a170902e14cb0290129d117fa3dmr19054634pla.53.1626688397949; Mon, 19 Jul 2021 02:53:17 -0700 (PDT) Received: from [10.200.196.235] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id c14sm21099059pgv.86.2021.07.19.02.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 02:53:17 -0700 (PDT) Subject: Re: [PATCH 1/7] mm: fix the deadlock in finish_fault() To: "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-2-zhengqi.arch@bytedance.com> <20210718212814.suvziikndiyezi6m@box.shutemov.name> From: Qi Zheng Message-ID: <9e97cedc-9fd7-4290-9f44-04b96acea15d@bytedance.com> Date: Mon, 19 Jul 2021 17:53:12 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210718212814.suvziikndiyezi6m@box.shutemov.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=WH2Ykao0; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0115250000A7 X-Stat-Signature: ecnxfdnz7a98dyx8z7pypq88fdu5i6gd X-HE-Tag: 1626688398-426241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/21 5:28 AM, Kirill A. Shutemov wrote: > On Sun, Jul 18, 2021 at 12:30:27PM +0800, Qi Zheng wrote: >> The commit 63f3655f9501(mm, memcg: fix reclaim deadlock with writeback) >> fix a deadlock bug by pre-allocating the pte page table outside of the >> page lock, the commit f9ce0be71d1f(mm: Cleanup faultaround and >> finish_fault() codepaths) rework the relevant code but ignore this race, >> fix it. >> >> Fixes: f9ce0be71d1f(mm: Cleanup faultaround and finish_fault() codepaths) >> Signed-off-by: Qi Zheng > > Acked-by: Kirill A. Shutemov > > and add stable@, please. > OK, I will add these in the patch v2, thanks.