From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE95C432BE for ; Thu, 12 Aug 2021 14:11:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E5AD61077 for ; Thu, 12 Aug 2021 14:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E5AD61077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7EFAB8D0002; Thu, 12 Aug 2021 10:11:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A0018D0001; Thu, 12 Aug 2021 10:11:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68EDB8D0002; Thu, 12 Aug 2021 10:11:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4AF148D0001 for ; Thu, 12 Aug 2021 10:11:22 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E58F8824999B for ; Thu, 12 Aug 2021 14:11:21 +0000 (UTC) X-FDA: 78466615962.38.DE95618 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id 67BCF50435A1 for ; Thu, 12 Aug 2021 14:11:21 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5905B1FF47; Thu, 12 Aug 2021 14:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628777480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltG9XPJTgXiAW64Yau60CHRwOU6O3fnGzP+EX5Voqfk=; b=ozwUzeBE3l7fsgaGC33rWU3XVDMUss29nM4ATaect5WZF8zBa+Wwq7Q7O+iitx+zIMYGE+ LNAqO2PEQqzit9I2z0RIBjqrGdaSXffcGufjO0obyB8LLsZymeU4Cnnx0ScFJVvLRXL0Cs VAjrSY40522Hu7QXzs+GZcwYnskwOQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628777480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltG9XPJTgXiAW64Yau60CHRwOU6O3fnGzP+EX5Voqfk=; b=sRXs1GKSGD6V2LMvRw105RYLEhIXcS02ZAvmjVaHJHZaorfkY8SMNk97ZDQVjnSKDU5ds5 go0G+lyqKOa3cbDA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 3B55E13A90; Thu, 12 Aug 2021 14:11:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id S6FEDQgsFWFzXwAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 14:11:20 +0000 Subject: Re: [PATCH v14 067/138] mm/writeback: Add folio_start_writeback() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-68-willy@infradead.org> From: Vlastimil Babka Message-ID: <9efcf51a-0375-6942-aadb-a83699eca456@suse.cz> Date: Thu, 12 Aug 2021 16:11:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-68-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ozwUzeBE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sRXs1GKS; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: yhtks5hy7kyt98egi1yz9byzgqspxru8 X-Rspamd-Queue-Id: 67BCF50435A1 X-Rspamd-Server: rspam05 X-HE-Tag: 1628777481-202641 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > Rename set_page_writeback() to folio_start_writeback() to match > folio_end_writeback(). Do not bother with wrappers that return void; > callers are perfectly capable of ignoring return values. > > Add wrappers for set_page_writeback(), set_page_writeback_keepwrite() and > test_set_page_writeback() for compatibililty with existing filesystems. > The main advantage of this patch is getting the statistics right, > although it does eliminate a couple of calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka