From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F01C433DB for ; Mon, 8 Mar 2021 14:13:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7345E64FB3 for ; Mon, 8 Mar 2021 14:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7345E64FB3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0CA68D002D; Mon, 8 Mar 2021 09:13:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBCC28D001D; Mon, 8 Mar 2021 09:13:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A36B08D002D; Mon, 8 Mar 2021 09:13:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 85E438D001D for ; Mon, 8 Mar 2021 09:13:43 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4E8DC824999B for ; Mon, 8 Mar 2021 14:13:43 +0000 (UTC) X-FDA: 77896900326.23.D825081 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 5DE77E007A46 for ; Mon, 8 Mar 2021 14:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615212821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgbBup6Vj344vbeikJWoQwoH+WZLtLaIQQ1FS0zc2MA=; b=EJLUHsEMCs4TRQrj9Mrs7M+toCdpN91b1OmhBXa4e0qSBb8Gx3/SBLV/6CUC5D7RfEpbod qt8gOLlUpTKxqiBkIHP6LUoVTzvB4WaVHQkeQv8cUSA0OWPakiSkYuAS95wzUOP2tvncY8 t4qCEYp7Hl97Q1o6/YSH/SiJcAL81hA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-151-NGWhpdnuNfq0M1wOFgsz6g-1; Mon, 08 Mar 2021 09:13:39 -0500 X-MC-Unique: NGWhpdnuNfq0M1wOFgsz6g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09EC9108BD12; Mon, 8 Mar 2021 14:13:38 +0000 (UTC) Received: from [10.36.113.123] (ovpn-113-123.ams2.redhat.com [10.36.113.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0C4A60C6E; Mon, 8 Mar 2021 14:13:36 +0000 (UTC) Subject: Re: [PATCH] mm: be more verbose for alloc_contig_range faliures To: Michal Hocko Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , joaodias@google.com References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <9f7b4b8a-5317-e382-7f21-01667e017982@redhat.com> Date: Mon, 8 Mar 2021 15:13:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Stat-Signature: pjhkwfpgwrdj78hoh9m7w876x6uaktj1 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5DE77E007A46 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615212817-756517 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.03.21 15:11, Michal Hocko wrote: > On Mon 08-03-21 14:22:12, David Hildenbrand wrote: >> On 08.03.21 13:49, Michal Hocko wrote: > [...] >>> Earlier in the discussion I have suggested dynamic debugging facility. >>> Documentation/admin-guide/dynamic-debug-howto.rst. Have you tried to >>> look into that direction? >> >> Did you see the previous mail this is based on: >> >> https://lkml.kernel.org/r/YEEUq8ZRn4WyYWVx@google.com >> >> I agree that "nofail" is misleading. Rather something like >> "dump_on_failure", just a better name :) > > Yeah, I have read through the email thread. I just do not get why we > cannot make it pr_debug() and add -DDYNAMIC_DEBUG_MODULE for > page_alloc.c (I haven't checked whether that is possible for built in > compile units, maybe it is not but from a quick seems it should). > > I really do not like this to be a part of the API. alloc_contig_range is Which API? It does not affect alloc_contig_range() itself, it's used internally only. Sure, we could simply pr_debug() for each and every migration failure. As long as it's default-disabled, sure. I do agree that we should look into properly including this into the dynamic debugging ifrastructure. -- Thanks, David / dhildenb