From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475DCC5517A for ; Fri, 6 Nov 2020 20:06:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0F0D2072E for ; Fri, 6 Nov 2020 20:06:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="JfoG/Ub5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0F0D2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2457C6B006C; Fri, 6 Nov 2020 15:06:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F5DF6B006E; Fri, 6 Nov 2020 15:06:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BDBC6B0070; Fri, 6 Nov 2020 15:06:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id D28586B006C for ; Fri, 6 Nov 2020 15:06:00 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6EB44180AD801 for ; Fri, 6 Nov 2020 20:06:00 +0000 (UTC) X-FDA: 77455074480.28.jeans88_510ec9a272d5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 4FCA66D65 for ; Fri, 6 Nov 2020 20:06:00 +0000 (UTC) X-HE-Tag: jeans88_510ec9a272d5 X-Filterd-Recvd-Size: 3918 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 20:05:59 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 06 Nov 2020 12:05:56 -0800 Received: from [10.2.172.112] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov 2020 20:05:57 +0000 From: Zi Yan To: Yang Shi CC: , , , , , , Subject: Re: [PATCH 4/5] mm: migrate: clean up migrate_prep{_local} Date: Fri, 6 Nov 2020 15:05:54 -0500 X-Mailer: MailMate (1.13.2r5673) Message-ID: In-Reply-To: <20201103130334.13468-5-shy828301@gmail.com> References: <20201103130334.13468-1-shy828301@gmail.com> <20201103130334.13468-5-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_627BF5E2-A770-4222-BE7B-7416578843FE_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604693156; bh=UwJKjrs0rWAJPVQAol3MpRv9KEwS4zvFE70qz0g/yAM=; h=From:To:CC:Subject:Date:X-Mailer:Message-ID:In-Reply-To: References:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=JfoG/Ub5AwxEi79X6YGUgqXgcpGBTh09tzWc0s9WgI9er9h5aUcn+eyLiwRsvETRB 5ViacpriScZfho9/ptDg8yL1J4EBJ52EoPQM1upgzRE2ihzETTbfXO5JIbF+FccPDV 9NEqSbb/6kC2wnA/ygU9tJFERZFzkd0JEI7Fnql/V82aEzhOz0j+5flH9QcY8N94Am PwCwr7m4+GZU/8fjs7iZp46AWImoKpjS6pDmvWoG4M65lH5jvZeslW7Yepc+w80Elj i2p+5Ui5cKsVHL5/tKuwrdY8kGShv7lOhG6pD2azqtk9cc7H23/zaso6er4Umvt/Bl 7H7/YLWx/7R0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_627BF5E2-A770-4222-BE7B-7416578843FE_= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 3 Nov 2020, at 8:03, Yang Shi wrote: > The migrate_prep{_local} never fails, so it is pointless to have return= > value and check the return value. > > Signed-off-by: Yang Shi > --- > include/linux/migrate.h | 4 ++-- > mm/mempolicy.c | 8 ++------ > mm/migrate.c | 8 ++------ > 3 files changed, 6 insertions(+), 14 deletions(-) > LGTM. Thanks. Reviewed-by: Zi Yan =E2=80=94 Best Regards, Yan Zi --=_MailMate_627BF5E2-A770-4222-BE7B-7416578843FE_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl+lrKIPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqK7c8P/3pnWRya6pnhnyoziSVErqcRCKPIDo68dMTw tNps1x3kpJA2xVZcHwzcloFj/3ektFsJv3p/WttOChJT00voWjGVP2/cTDiP7QfD 5hHg66/jFDDBvehWBD54ELFsPlENb8zmNr8dwF9wknLZwN7EvpCccRcR9C2uOHYQ 5u++18mzmJs2xvVtUwbosIcC/WZgooFNfX+v/GN3eQ+WKQGNmlYlQ5I+FZbLycAs MUjIKC+Au942pYspHMiLhpK3ARPCDb6UcFuiLSGEpehrWZ4kzeLdxXRL6/wth/Xd /ZB5CGdqVgMFPoU5qX9UUpseOua+tw/ggCNVOyrE/RxYlb2nNPS4s3tNcJYFt+cO 2+MbaLxfxJjejVoDg/Nxbc8bBwGyYcq8xklg4RXMhuo8v2AGDE9+gC0LIHWtuObz ZpG8GYtQk7XtBjLZmkKFRY9WXok+p7GlVJ+2W3S8VxolRjK9WONE1+5Vc7HDhesV v7KXV1MNj4f1Owq/c05kczXSoGpKPHH/riNt+z+mEmESPXnhNFgOJVGUjpBuyHUD kS/QVysf6a9eu1ni9vvYpk//D+yItcSEUDgMCh1ACopUXl8JIUtpgqQFdnqB5cOk iGfWS5VZ5nmz+JWmCOlWl6kLJEQ29MeeDakt+3YYadxepvKWH0cppTVye7/LLtAe nppDQwih =IKpN -----END PGP SIGNATURE----- --=_MailMate_627BF5E2-A770-4222-BE7B-7416578843FE_=--