From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Andrei Vagin <avagin@gmail.com>, Ingo Molnar <mingo@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Yuyang Du <duyuyang@gmail.com>,
David Hildenbrand <david@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Anshuman Khandual <anshuman.khandual@arm.com>,
David Howells <dhowells@redhat.com>,
James Morris <jamorris@linux.microsoft.com>,
Shakeel Butt <shakeelb@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Christian Kellner <christian@kellner.me>,
Andrea Arcangeli <aarcange@redhat.com>,
Aleksa Sarai <cyphar@cyphar.com>,
"Dmitry V. Levin" <ldv@altlinux.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v6 00/16] Infrastructure to allow fixing exec deadlocks
Date: Wed, 25 Mar 2020 16:33:58 +0100 [thread overview]
Message-ID: <AM6PR03MB51705AB7D87FA2B1B2FA7E9DE4CE0@AM6PR03MB5170.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <871rpg8o7v.fsf@x220.int.ebiederm.org>
On 3/25/20 4:10 PM, Eric W. Biederman wrote:
> Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
>
>> This is an infrastructure change that makes way for fixing this issue.
>> Each patch was already posted previously so this is just a cleanup of
>> the original mailing list thread(s) which got out of control by now.
>>
>> Everything started here:
>> https://lore.kernel.org/lkml/AM6PR03MB5170B06F3A2B75EFB98D071AE4E60@AM6PR03MB5170.eurprd03.prod.outlook.com/
>>
>> I added reviewed-by tags from the mailing list threads, except when
>> withdrawn.
>>
>> It took a lot longer than expected to collect everything from the
>> mailinglist threads, since several commit messages have been infected
>> with typos, and they got fixed without a new patch version.
>>
>> - Correct the point of no return.
>> - Add two new mutexes to replace cred_guard_mutex.
>> - Fix each use of cred_guard_mutex.
>> - Update documentation.
>> - Add a test case.
>>
>> Bernd Edlinger (11):
>> exec: Fix a deadlock in strace
>> selftests/ptrace: add test cases for dead-locks
>> mm: docs: Fix a comment in process_vm_rw_core
>> kernel: doc: remove outdated comment cred.c
>> kernel/kcmp.c: Use new infrastructure to fix deadlocks in execve
>> proc: Use new infrastructure to fix deadlocks in execve
>> proc: io_accounting: Use new infrastructure to fix deadlocks in execve
>> perf: Use new infrastructure to fix deadlocks in execve
>> pidfd: Use new infrastructure to fix deadlocks in execve
>> exec: Fix dead-lock in de_thread with ptrace_attach
>> doc: Update documentation of ->exec_*_mutex
>>
>> Eric W. Biederman (5):
>> exec: Only compute current once in flush_old_exec
>> exec: Factor unshare_sighand out of de_thread and call it separately
>> exec: Move cleanup of posix timers on exec out of de_thread
>> exec: Move exec_mmap right after de_thread in flush_old_exec
>> exec: Add exec_update_mutex to replace cred_guard_mutex
>>
>> Documentation/security/credentials.rst | 29 +++++--
>> fs/exec.c | 122 ++++++++++++++++++++++--------
>> fs/proc/base.c | 23 +++---
>> include/linux/binfmts.h | 8 +-
>> include/linux/sched/signal.h | 17 ++++-
>> init/init_task.c | 3 +-
>> kernel/cred.c | 4 +-
>> kernel/events/core.c | 12 +--
>> kernel/fork.c | 7 +-
>> kernel/kcmp.c | 8 +-
>> kernel/pid.c | 4 +-
>> kernel/ptrace.c | 20 ++++-
>> kernel/seccomp.c | 15 ++--
>> mm/process_vm_access.c | 2 +-
>> tools/testing/selftests/ptrace/Makefile | 4 +-
>> tools/testing/selftests/ptrace/vmaccess.c | 86 +++++++++++++++++++++
>> 16 files changed, 278 insertions(+), 86 deletions(-)
>> create mode 100644 tools/testing/selftests/ptrace/vmaccess.c
>
> Two small nits.
>
> - You reposted my patches with adding your signed-off-by
> - You reposted my patches and did not include a "From:"
> in the body so "git am" listed you as the author.
>
> I have fixed those up and will be merging this code to linux-next,
> unless you object.
>
Thanks, I have not expected that a From: which names a different domain
than hotmail.de would be forwarded by the SMTP servers I have to use.
Actually I was not even aware of the problem at all.
The Patch "exec: Add exec_update_mutex to replace cred_guard_mutex"
was initially reviewed-by: bernd.edlinger@hotmail.de but it turned out
to be faulty, so I update your patch faithfully, and did a small change
to fix the patch, therefore it is actually 99% your and 1% my patch,
therefore I figured I should be in a signed-off-by: together with you.
BTW: I saw a Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com> on the mailing list,
you should add that as well.
Thanks
Bernd.
next prev parent reply other threads:[~2020-03-25 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 20:24 [PATCH v6 00/16] Infrastructure to allow fixing exec deadlocks Bernd Edlinger
2020-03-25 15:10 ` Eric W. Biederman
2020-03-25 15:33 ` Bernd Edlinger [this message]
2020-03-28 22:32 ` Bernd Edlinger
2020-03-29 3:44 ` Kees Cook
[not found] ` <AM6PR03MB5170E0E722ED0B05B149C135E4CB0@AM6PR03MB5170.eurprd03.prod.outlook.com>
[not found] ` <20200330201459.GF22483@bombadil.infradead.org>
2020-04-02 7:40 ` Kees Cook
2020-04-02 7:43 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR03MB51705AB7D87FA2B1B2FA7E9DE4CE0@AM6PR03MB5170.eurprd03.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=avagin@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=christian.brauner@ubuntu.com \
--cc=christian@kellner.me \
--cc=corbet@lwn.net \
--cc=cyphar@cyphar.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=duyuyang@gmail.com \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jamorris@linux.microsoft.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=ktkhai@virtuozzo.com \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).