From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0320DC4332D for ; Thu, 19 Mar 2020 07:19:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA0792051A for ; Thu, 19 Mar 2020 07:19:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA0792051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 64ACD6B0003; Thu, 19 Mar 2020 03:19:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FB746B0005; Thu, 19 Mar 2020 03:19:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EBA26B0006; Thu, 19 Mar 2020 03:19:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 344396B0003 for ; Thu, 19 Mar 2020 03:19:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D1977381E for ; Thu, 19 Mar 2020 07:19:28 +0000 (UTC) X-FDA: 76611261216.22.patch27_358fbff2bfc44 X-HE-Tag: patch27_358fbff2bfc44 X-Filterd-Recvd-Size: 8045 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075033.outbound.protection.outlook.com [40.92.75.33]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 07:19:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mrUPWrUqOaKWAf1aMquFWlh4Oy1/f/HAOKhSlD6Lq7bfYuyHysoA+YgnYq7Tig7teDFyTX0FYGrpM1WYW6k2B5RbRd7LgR7rGzMpGL+HWtwOhFAlLolluq/4qRWH8uSBTVO9tObA5433/I46ZARG8P0T/H3ujw5AqC/5pp24sITW4VaZMadUMjmT74O3B6LDzPADDqKTnPD0RRY1LhVWLq9M6ZFy+x8KltzZPmLxEAbRQFI0azbnGkXg8kjjTDtwxV924ubNMyAQODVOwNLkXxCIFchEqXhCSihTSMTfhFwhfZwdvna9EfBIbB1zMkXt/uyLDKJy+5oMLneZtUTp2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vxIBA0eTTJmtvzqWujapOEKtGUqHaJJ9YhL5aqFDIao=; b=JW99FeZsWUIITD8fpMR3hGfOMBcqQrH7wYWyz0Fga13fF43wnK+J2vMKuFm6ns93H/AZwamPUZf8a1YqxzaKbMzsRKe2EQoVFLz0dwtihP9NAL7uPbvBmvcDHgKQGrXzLivWI1+9GGcQPCM/Bu96k/qunjdNmd8I7AUw7AE83zf50jfKCUtTj/KcnlXKDQBft9ZW9YcGqScztgHYmPgIQiiEk7HdXlbjxLnC9u1VlvEEG3a/CVHU/9CFMzhNndnf2G7Y5BMd28HTpWjcnL4DIPTmqZi+DXoRuieAZRoTFvGIAKzOjy7Qc51E6yKRkjHXV6HHnVEiL0ThfNxCPJUcbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from HE1EUR04FT040.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::39) by HE1EUR04HT022.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13; Thu, 19 Mar 2020 07:19:25 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (10.152.26.56) by HE1EUR04FT040.mail.protection.outlook.com (10.152.26.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13 via Frontend Transport; Thu, 19 Mar 2020 07:19:25 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:B5C2B2B81A31B114FA65B0D3F3DB93E518946F7458CE334BF9BEEB6C89AFCEC9;UpperCasedChecksum:D4F0E88236249F7EB1A0DF7531DD5D2B4DADEA94CB0CF94780BC0E257E4A6F30;SizeAsReceived:10330;Count:50 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::1956:d274:cab3:b4dd%6]) with mapi id 15.20.2835.017; Thu, 19 Mar 2020 07:19:25 +0000 Subject: Re: [PATCH v3 5/5] exec: Add a exec_update_mutex to replace cred_guard_mutex To: Kirill Tkhai , "Eric W. Biederman" Cc: Christian Brauner , Kees Cook , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" References: <87tv32cxmf.fsf_-_@x220.int.ebiederm.org> <87v9ne5y4y.fsf_-_@x220.int.ebiederm.org> <87zhcq4jdj.fsf_-_@x220.int.ebiederm.org> <87d09hn4kt.fsf@x220.int.ebiederm.org> <87lfo5lju6.fsf@x220.int.ebiederm.org> <6002ac56-025a-d50f-e89d-1bf42a072323@virtuozzo.com> <532ce6a3-f0df-e3e4-6966-473c608246e1@virtuozzo.com> <13c4d333-9c33-8036-3142-dac22c392c60@virtuozzo.com> From: Bernd Edlinger Message-ID: Date: Thu, 19 Mar 2020 08:19:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::25) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <5e38267c-cb7f-8049-26b8-3a0a155ca51a@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by FR2P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.19 via Frontend Transport; Thu, 19 Mar 2020 07:19:24 +0000 X-Microsoft-Original-Message-ID: <5e38267c-cb7f-8049-26b8-3a0a155ca51a@hotmail.de> X-TMN: [m8LpYdCrZRxzdlzBeoQ2jXshgvDIn49Y] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 6f08d5e8-2023-42ff-f29b-08d7cbd5da79 X-MS-TrafficTypeDiagnostic: HE1EUR04HT022: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /X3jasuoM4he5VZ9efsssHDT2JLhi+bxnFrvMzKBipdJq7PD6e1D3/bieeI+FRYDf1zu8JdLQmLUzGDcaXiDwKTRfzWDlY4HKjKE1ClgnhUj/k1I4A0xVwI9yQP0cDl3+OODdh/HupnOxdzAZ6UwpbpvWEJxgTkH/ntX1CCGMo+usNsJbOlaazkqIIBvXCVq X-MS-Exchange-AntiSpam-MessageData: oK1Nj1SgfWb6a6HS+SOIRMvtP8Dk22KU8zlA/X9NBlFcG2WdV9gjSZSZq4/B5BXm38PHa2SVMw3oR2Ff4pKPD3eBa2RPrJmDDXxkgrdHqhsUh7iJDtEjjA2UjoJY/rG0uZBmz3FKFDndoIrTvEzKSQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f08d5e8-2023-42ff-f29b-08d7cbd5da79 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2020 07:19:25.4399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR04HT022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/19/20 8:13 AM, Kirill Tkhai wrote: > On 18.03.2020 23:06, Bernd Edlinger wrote: >> >> I was thinking of something like that: >> >> --- a/fs/exec.c >> +++ b/fs/exec.c >> @@ -1010,6 +1010,11 @@ ssize_t read_code(struct file *file, unsigned long addr, >> } >> EXPORT_SYMBOL(read_code); >> >> +/* >> + * Maps the mm_struct mm into the current task struct. >> + * On success, this function returns with the mutex >> + * exec_update_mutex locked. >> + */ > > Looks OK for me. > Cool, yeah, then I will post an updated patch in a moment. Thanks Bernd.